From owner-cvs-all@FreeBSD.ORG Thu Jul 26 19:33:01 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E746616A417; Thu, 26 Jul 2007 19:33:01 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 8384E13C459; Thu, 26 Jul 2007 19:33:01 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 9927045685; Thu, 26 Jul 2007 21:12:47 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 58B0A4569A; Thu, 26 Jul 2007 21:12:42 +0200 (CEST) Date: Thu, 26 Jul 2007 21:12:01 +0200 From: Pawel Jakub Dawidek To: John Baldwin Message-ID: <20070726191201.GR12473@garage.freebsd.pl> References: <200707261658.l6QGwAs8038591@repoman.freebsd.org> <200707261418.59436.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kOdvwer/5gjFgNo6" Content-Disposition: inline In-Reply-To: <200707261418.59436.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2007 19:33:02 -0000 --kOdvwer/5gjFgNo6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 26, 2007 at 02:18:58PM -0400, John Baldwin wrote: > On Thursday 26 July 2007 12:58:10 pm Pawel Jakub Dawidek wrote: > > pjd 2007-07-26 16:58:09 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/fs/devfs devfs_vnops.c=20 > > sys/fs/fifofs fifo_vnops.c=20 > > sys/kern uipc_usrreq.c vfs_vnops.c=20 > > sys/vm vnode_pager.c=20 > > Log: > > When we do open, we should lock the vnode exclusively. This fixes few= =20 > races: > > - fifo race, where two threads assign v_fifoinfo, > > - v_writecount modifications, > > - v_object modifications, > > - and probably more... >=20 > Is it possible this could fix some 'vrele: negative ref cnt' and 'vput:= =20 > negative ref cnt' panics I am seeing on 6.x? I see similar panic on NFS root vnode, but this change won't fix it. v_usecount is protected by vnode's internal lock, not vnode lock. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --kOdvwer/5gjFgNo6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGqPIBForvXbEpPzQRAvZgAJ965qgQTKO/Y/RsxM3Z6zsw0TceoQCePs6D 1VIj4WItNSzNEkiPbMi3RbY= =3QUl -----END PGP SIGNATURE----- --kOdvwer/5gjFgNo6--