From owner-svn-src-head@freebsd.org Fri Aug 23 15:53:19 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A58EAC853B for ; Fri, 23 Aug 2019 15:53:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46FQsp3F8Vz3Pyl for ; Fri, 23 Aug 2019 15:53:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72b.google.com with SMTP id m10so8577831qkk.1 for ; Fri, 23 Aug 2019 08:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NxAVg8SucpmXbz7R3PsLE5rEjDtyo9+OVbunW7SATAM=; b=Mxcz9NPz8JOU2C75yzVkrEvz+TXAanNh2GWvDvFziUAumE5dh7ChOr76dA08tH6BJJ G2YwtmvF5PUJMBtH21kQW9mD1cz3FPR/nJcqCfOqbL4Ex+zM3x+4jIBt0ZT151h2T6dh uygIo2MysOcKiyq98emgZpWLGwLLnRBBElxKJIeo72BnqXE81EXHNJakgJoSx/+Y1Cuv iUAuPh91d+fzHXlGoBu0/WKTtNzjfIavCL1XXzZdER+5Je2WFghckAcs0rJhhSV6fUZm e9yZBh0ZO0GPcq4YT7M5Xft5e5BuixjPOgHJvSBDQw0qE1TtBft54behiCL29zFEna7H 82ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NxAVg8SucpmXbz7R3PsLE5rEjDtyo9+OVbunW7SATAM=; b=eF96R+G77zRIdnhuJCwatQXGAOHvIOME2q1R87Rpi+pRYSPI3zUZDPMVJ7ousQ++Yw garYCdIQ4btqrtWl7S5HuGhbaFrrEDW29Yz64xWOdqejYlTv8HwcywjBT4xeZmRSbb+g TpJ+nM9DI1JFrzrZ80Ii4bJOdqKK5+MqIvmYbSo0XwfSwY95tGPBgcYgQjX/4/xSr0pD ZdiIDsgKH/xV5A7mHw9P5oriXKjcV9jloVrOrXh0271OVADuwiibmvNdlDkUeaOUG33r VPYJ0w69JaX0bvksCKYq6dB3bZzTrSg+ToyW757NeAJk8iSs/+BTpSjgUF1rB5Mays0e Lkhg== X-Gm-Message-State: APjAAAWUoDLuoD6IUJS767EkwlrrGY5YHQRd+KsYyts7v9PEBm38Sjmf j/EVrNxOX0GKrvvAxCgEJRYFR3VUHDRHy/pdAH0CrA== X-Google-Smtp-Source: APXvYqySP5pzFDFBttde27/CbSRXHHurZR80x42pgH3LjMqfahHmLW6YQG2sOE5FzeaNHoLcetFjDhXz+VF4RKbwQKo= X-Received: by 2002:a37:4804:: with SMTP id v4mr4928514qka.60.1566575596923; Fri, 23 Aug 2019 08:53:16 -0700 (PDT) MIME-Version: 1.0 References: <201908220002.x7M028Jh070116@repo.freebsd.org> <0b9d1aa1-d328-30bc-b939-f1407e236855@FreeBSD.org> In-Reply-To: <0b9d1aa1-d328-30bc-b939-f1407e236855@FreeBSD.org> From: Warner Losh Date: Fri, 23 Aug 2019 09:53:05 -0600 Message-ID: Subject: Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto To: John Baldwin Cc: "Bjoern A. Zeeb" , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46FQsp3F8Vz3Pyl X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Mxcz9NPz; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72b) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.94 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[9]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.992,0]; RCVD_IN_DNSWL_NONE(0.00)[b.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.95)[ip: (-9.48), ipnet: 2607:f8b0::/32(-2.88), asn: 15169(-2.34), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2019 15:53:19 -0000 Sorry for top posting... I had planned this for next week, but I think give this insanity of this patch, we should do it now: turn off -Werror for gcc 4.2.1 https://reviews.freebsd.org/D21378 has the review. There's no benefit to these head-scratcher changes when we can get the same benefit by ignoring gcc 4.2.1 errors as discussed on arch@. Warner On Thu, Aug 22, 2019 at 10:46 AM John Baldwin wrote: > On 8/22/19 2:39 AM, Bjoern A. Zeeb wrote: > > On 22 Aug 2019, at 0:02, John Baldwin wrote: > > > > Hi, > > > >> Author: jhb > >> Date: Thu Aug 22 00:02:08 2019 > >> New Revision: 351364 > >> URL: https://svnweb.freebsd.org/changeset/base/351364 > >> > >> Log: > >> Use 'const' for keys and IVs passed to software encryption > >> algorithms. > >> > >> Specifically, use 'const' for the key passed to the 'setkey' method > >> and 'const' for the 'iv' passed to the 'reinit' method. > >> > >> Reviewed by: cem > >> Sponsored by: Chelsio Communications > >> Differential Revision: https://reviews.freebsd.org/D21347 > > > > can you please review and commit this one to make gcc platforms a bit > > more happy again (I tested a sparc64 GENERIC kernel build): > > I will get tinderbox happy. > > > Index: sys/opencrypto/xform_des3.c > > =================================================================== > > --- sys/opencrypto/xform_des3.c (revision 351384) > > +++ sys/opencrypto/xform_des3.c (working copy) > > @@ -100,9 +100,9 @@ des3_setkey(u_int8_t **sched, const u_int8_t *key, > > p = KMALLOC(3*sizeof (des_key_schedule), > > M_CRYPTO_DATA, M_NOWAIT|M_ZERO); > > if (p != NULL) { > > - des_set_key((const des_cblock *)(key + 0), p[0]); > > - des_set_key((const des_cblock *)(key + 8), p[1]); > > - des_set_key((const des_cblock *)(key + 16), p[2]); > > + des_set_key(__DEQUALIFY(const des_cblock *,(key + 0)), > p[0]); > > + des_set_key(__DEQUALIFY(const des_cblock *,(key + 8)), > p[1]); > > + des_set_key(__DEQUALIFY(const des_cblock *,(key + 16)), > p[2]); > > This makes no sense. Why are you removing const only to add it back again? > > -- > John Baldwin > >