From owner-freebsd-audit Tue May 15 4:57:45 2001 Delivered-To: freebsd-audit@freebsd.org Received: from green.bikeshed.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 60CB137B423; Tue, 15 May 2001 04:57:42 -0700 (PDT) (envelope-from green@green.bikeshed.org) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.2/8.11.1) with ESMTP id f4FBvaw71562; Tue, 15 May 2001 07:57:40 -0400 (EDT) (envelope-from green@green.bikeshed.org) Message-Id: <200105151157.f4FBvaw71562@green.bikeshed.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Ruslan Ermilov Cc: Alfred Perlstein , audit@FreeBSD.org, freebsd-standards@bostonradio.org Subject: Re: Please review: new implementation of hsearch(3) In-Reply-To: Message from Ruslan Ermilov of "Tue, 15 May 2001 09:40:12 +0300." <20010515094012.A14389@sunbay.com> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 15 May 2001 07:57:35 -0400 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Ruslan Ermilov wrote: > On Mon, May 14, 2001 at 12:12:57PM -0700, Alfred Perlstein wrote: > > * Ruslan Ermilov [010514 12:10] wrote: > > > Hi! > > > > > > Our current hsearch(3) implementation is buggy in many ways. > > > The most limiting factor is that it can only handle char * > > > item.data despite the type was recently changed to void *. > > > (See example in the manpage.) > > > > > > The attached patch merely merges NetBSD re-implementation of > > > the hsearch(3), which is POSIX.1-200x conformant. > > > > Nice, it'd be sorta cool if we offered expanded versions that > > allowed for more than one hash table at a time. > > > But these are POSIX compatible :-) I was thinking the same thing. Do something exactly like how strtok_r() and strtok() are done :) That doesn't add much overhead or effort at all. -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message