From owner-freebsd-hackers@FreeBSD.ORG  Tue Oct  5 15:27:48 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E92621065763
	for <freebsd-hackers@freebsd.org>; Tue,  5 Oct 2010 15:27:47 +0000 (UTC)
	(envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 4ECBE8FC33
	for <freebsd-hackers@freebsd.org>; Tue,  5 Oct 2010 15:27:45 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA28533;
	Tue, 05 Oct 2010 18:27:43 +0300 (EEST)
	(envelope-from avg@freebsd.org)
Message-ID: <4CAB43EF.8010807@freebsd.org>
Date: Tue, 05 Oct 2010 18:27:43 +0300
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.9) Gecko/20100920 Lightning/1.0b2 Thunderbird/3.1.4
MIME-Version: 1.0
To: freebsd-hackers@freebsd.org
References: <4CA4C63F.4070503@icyb.net.ua>
In-Reply-To: <4CA4C63F.4070503@icyb.net.ua>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Ed Maste <emaste@freebsd.org>
Subject: Re: sysctl for querying kmem_map->size
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Oct 2010 15:27:49 -0000

on 30/09/2010 20:17 Andriy Gapon said the following:
> 
> Here's a patch that adds a sysctl for querying kmem_map->size, which may be useful
> for system state/resources monitoring:
> http://people.freebsd.org/~avg/sysctl-kmem_map_size.diff
> 
> I am quite unsure about sizeof(kmem_map->size) == sizeof(int) hack, but I couldn't
> think of other way to decide whether to use SYSCTL_ADD_UINT or SYSCTL_ADD_ULONG
> depending on real type behind vm_size_t.

Here's an updated patch:
http://people.freebsd.org/~avg/sysctl-kmem_map_size2.diff
The new code wraps kmem_map->size into SYSCTL_PROC() to handle vm_size_t type
differences for different platforms.  The idea is suggested by Ed Maste.


-- 
Andriy Gapon