From owner-freebsd-ports-bugs@freebsd.org Wed Jan 20 12:05:50 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69BC3A8A11A for ; Wed, 20 Jan 2016 12:05:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4E7481CFB for ; Wed, 20 Jan 2016 12:05:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u0KC5nlg068003 for ; Wed, 20 Jan 2016 12:05:50 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205805] Mk/bsd.qt.mk: Update to 5.5.1 Date: Wed, 20 Jan 2016 12:05:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kde@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2016 12:05:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205805 --- Comment #13 from Raphael Kubo da Costa --- (In reply to Raphael Kubo da Costa from comment #12) > I'll post some specific questions later. OK, here we go. I hope you're still around to look at the comments, answer = them and hopefully start contributing to our experimental repositories in the future. First, some comments about things which have been fixed or implemented differently in area51: * Changes in USE_QT5 in many ports: this prompted me to take a look at the situation. Indeed we were linking against many libraries without declaring them. However, I chose to fix it differently, and instead of just adjusting USE_QT5 I switched to building the Qt5 ports with -Wl,--as-needed so that t= he final binaries only really link against the libraries that they actually ne= ed. See http://src.mouf.net/area51/revision?rev=3D11818 and http://src.mouf.net/area51/revision/?rev=3D11827. * Adding USE_QT5=3Dwebchannel to webkit-qt5 doesn't make much sense, and ad= ding gstreamer-0.10 as a dependency is wrong. It must use GStreamer 1.0, like it already does. Ditto for qt5-multimedia. * Your change to qt5-printsupport's Makefile was partially right, see comme= nt #10 for all the required changes. * I've net/libproxy as a dependency for net/qt5-network following your chan= ge. It required some additional work: http://src.mouf.net/area51/revision/?rev=3D11824 * The patches you've added to qt5-core are wrong, see their versions in are= a51. Basically those things have all been fixed upstream, and importing the patc= hes from there is the right thing to do. Now things that still need clarification from your patch: * Why was patch-src__designer__src__src.pro removed from devel/qt5-uitools? * Why the changes to the filterLibraryOptions calls in extrapatch-configure? * I don't get why you added USES=3Dgettext to several ports. * I don't get why you need the post-patch changes you added to qt5-gui. * I don't get any of the PCRE-related changes you've made to qt5-core and q= t5. * Why was patch-3rdparty__clucene__src__CLucene__search__FieldCacheImpl.cpp removed from textproc/clucene-qt5? It was originally added because of bug 169872. It might not be needed anymore, but I need more context and confirmation that you tested it. --=20 You are receiving this mail because: You are on the CC list for the bug.=