From owner-svn-src-projects@FreeBSD.ORG  Wed Feb 11 11:20:21 2009
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6B09F106564A
	for <svn-src-projects@freebsd.org>;
	Wed, 11 Feb 2009 11:20:21 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E0E78FC08
	for <svn-src-projects@freebsd.org>;
	Wed, 11 Feb 2009 11:20:20 +0000 (UTC) (envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 3F5566D44C;
	Wed, 11 Feb 2009 11:05:18 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 17ABF844BA; Wed, 11 Feb 2009 12:05:18 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Kirk McKusick <mckusick@FreeBSD.org>
References: <200902100811.n1A8Bigw085658@svn.freebsd.org>
Date: Wed, 11 Feb 2009 12:05:17 +0100
In-Reply-To: <200902100811.n1A8Bigw085658@svn.freebsd.org> (Kirk McKusick's
	message of "Tue, 10 Feb 2009 08:11:44 +0000 (UTC)")
Message-ID: <86iqnhnsia.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r188434 - projects/quota64/lib/libutil
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2009 11:20:21 -0000

Kirk McKusick <mckusick@FreeBSD.org> writes:
> @@ -231,7 +231,7 @@ quota_write32(struct quotafile *qf, cons
>  	off =3D id * sizeof(struct dqblk32);
>  	if (lseek(qf->fd, off, SEEK_SET) =3D=3D -1)
>  		return (-1);
> -	return (write(qf->fd, &dqb32, sizeof(dqb32)));
> +	return (write(qf->fd, &dqb32, sizeof(dqb32)) =3D=3D -1);
>  }
>=20=20
>  static int

I would prefer -1 for failure and 0 for success...

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no