From owner-svn-src-all@freebsd.org Thu Jan 30 20:57:41 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 92BE51FEC07; Thu, 30 Jan 2020 20:57:41 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 487t381RKSz4fNw; Thu, 30 Jan 2020 20:57:39 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id 00UKvbFE057302 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 30 Jan 2020 12:57:37 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id 00UKvbOe057301; Thu, 30 Jan 2020 12:57:37 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Thu, 30 Jan 2020 12:57:37 -0800 From: Gleb Smirnoff To: Jeff Roberson Cc: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap Message-ID: <20200130205737.GL1268@FreeBSD.org> References: <202001301028.00UAS1s1063130@repo.freebsd.org> <20200130204322.GJ1268@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 487t381RKSz4fNw X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.83 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.96)[-0.960,0]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; NEURAL_HAM_LONG(-0.87)[-0.872,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 20:57:41 -0000 On Thu, Jan 30, 2020 at 10:51:23AM -1000, Jeff Roberson wrote: J> On Thu, 30 Jan 2020, Gleb Smirnoff wrote: J> J> > On Thu, Jan 30, 2020 at 10:28:01AM +0000, Hans Petter Selasky wrote: J> > H> Author: hselasky J> > H> Date: Thu Jan 30 10:28:01 2020 J> > H> New Revision: 357291 J> > H> URL: https://svnweb.freebsd.org/changeset/base/357291 J> > H> J> > H> Log: J> > H> Widen EPOCH(9) usage in PCI WLAN drivers. J> > H> J> > H> Make sure all occurrences of ieee80211_input_xxx() in sys/dev are J> > H> covered by a network epoch section. Do not depend on the interrupt J> > H> handler nor any taskqueues being in a network epoch section. J> > H> J> > H> This patch should unbreak the PCI WLAN drivers after r357004. J> > H> J> > H> Pointy hat: glebius@ J> > H> Sponsored by: Mellanox Technologies J> > J> > Hey, I have reviewed all of them. J> > J> > The following drivers were not broken, and your change does 100% J> > recursive epoch_enter: J> > J> > bwi, ipw, iwi, iwm, iwn, ral, rtwn, wi, wpi J> > J> > The following drivers use taskq and would be fixed by D23408: J> > J> > bwn, malo, mwl, wtap J> > J> > P.S. A funny note about wtap. You modified even a function that J> > is a dead code - wtap_rx_deliver(). Gives some clue on quality J> > of your sweep over all drivers. J> J> I would strongly suggest that we not make more changes to this area J> without a discussion on a review to make sure we're all in agreement. J> There are some fine technical details which would benefit from multiple J> eyes and failing to act together is creating more conflict than is J> necessary. I volunteer to be on the reviews as an impartial third party. Don't worry, I'm not going to participate in the commit war Hans started. -- Gleb Smirnoff