From owner-freebsd-ports@FreeBSD.ORG  Sun May 25 07:09:47 2014
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 64959352;
 Sun, 25 May 2014 07:09:47 +0000 (UTC)
Received: from mail-pb0-x22e.google.com (mail-pb0-x22e.google.com
 [IPv6:2607:f8b0:400e:c01::22e])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 382C62519;
 Sun, 25 May 2014 07:09:47 +0000 (UTC)
Received: by mail-pb0-f46.google.com with SMTP id rq2so6147675pbb.33
 for <multiple recipients>; Sun, 25 May 2014 00:09:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=Sim233ioSjcewRJ4NtmcFZG5NOcwjR5AIygo+CIpubk=;
 b=Uona4LN7g9pwB0vcefmGaAg/gAaC87JrcQvFUR4/sr6U/T+kDZybO7f+uS/nqhz+yE
 kxnBLdMaBT3oMhbL0YKdyzVUSb53lZtpEiJrsLSBY1nn9pIlqwLg3yhqNENPcpOU8xiR
 x5u80qXdi3hD43HYjEIQDjy8a0ZMiyJlQK49f4fy2TFsBJaop1HkrUjgqldFm4KIkDV+
 V6P5mK7Q8iLppQdLn99+7cPQp10zbPqG3X0b4mEyd9FGd2HJrezHA0KCkToAeQmbL/LD
 CRqTUfvDkdLZiVVAVp3p3l+Yo8u/08PtuQg+MfjV/v2lhgqvUQ7th6hM6qGKQzGNfhCJ
 GxWg==
MIME-Version: 1.0
X-Received: by 10.66.228.133 with SMTP id si5mr19108912pac.48.1401001786808;
 Sun, 25 May 2014 00:09:46 -0700 (PDT)
Received: by 10.70.29.131 with HTTP; Sun, 25 May 2014 00:09:46 -0700 (PDT)
In-Reply-To: <538179d9.ERL3ZKEnk4pQKKib%perryh@pluto.rain.com>
References: <524CE820.5060003@missouri.edu>
 <20131003061511.GF85314@ithaqua.etoilebsd.net>
 <538179d9.ERL3ZKEnk4pQKKib%perryh@pluto.rain.com>
Date: Sun, 25 May 2014 09:09:46 +0200
Message-ID: <CADtCJqoTpSB0E9uN8Y6CkZm_8wjU0b5Pc50vT=pB-bHjZmGpeQ@mail.gmail.com>
Subject: Re: Is staging a port really this simple?
From: Zsolt Udvari <udvzsolt@gmail.com>
To: Perry Hutchison <perryh@pluto.rain.com>
Content-Type: text/plain; charset=UTF-8
Cc: bapt@freebsd.org, FreeBSD Ports mailing list <freebsd-ports@freebsd.org>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 May 2014 07:09:47 -0000

2014-05-25 7:04 GMT+02:00 Perry Hutchison <perryh@pluto.rain.com>:
>  post-install:
> -       @[ -f ${PREFIX}/etc/diskcheckd.conf ] \
> -               || ${CP} -p ${PREFIX}/etc/diskcheckd.conf.sample \
> -                       ${PREFIX}/etc/diskcheckd.conf
> +       @[ -f ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf ] \
> +               || ${CP} -p ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf.sample \
> +                       ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf
Your condition is unneeded.
You don't need check the existence of
${STAGEDIR}${PREFIX}/etc/distcheckd.conf because you'll copy it, the
${STAGEDIR} are empty!!!!
The reason of "old" check was: shouldn't overwrite the existing
distcheckd.conf (in system, not STAGEDIR). These checks are
unnecessary, the 'pkg' does it.

Cheers,
  Zsolt