From owner-freebsd-net@freebsd.org  Mon Oct 19 06:21:16 2015
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39DE1A18837
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Mon, 19 Oct 2015 06:21:16 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 by mx1.freebsd.org (Postfix) with ESMTP id 2444610B7
 for <freebsd-net@freebsd.org>; Mon, 19 Oct 2015 06:21:16 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346)
 id 20895107D2F; Mon, 19 Oct 2015 06:21:16 +0000 (UTC)
Date: Mon, 19 Oct 2015 06:21:16 +0000
To: freebsd-net@freebsd.org
From: "hrs (Hiroki Sato)" <phabric-noreply@FreeBSD.org>
Reply-to: D1986+325+381818416dc12ca2@reviews.freebsd.org
Subject: [Differential] [Commented On] D1986: Teach lagg(4) to change MTU
Message-ID: <d8113bc862d3cb74a50dab7d304cd0be@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-cc>, <differential-comment>
Thread-Topic: D1986: Teach lagg(4) to change MTU
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-gxjszcyr3icxaytfydyu>
X-Phabricator-To: <PHID-USER-vtlauz4uwe46gac4fu2j>
X-Phabricator-Cc: <PHID-USER-jfdfp3ujmysz623mloir>
X-Phabricator-Cc: <PHID-USER-u62wa6uhdoiyjmodxchd>
X-Phabricator-Cc: <PHID-USER-m472qpdkxj722xbzguun>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-USER-e73re76ob52gi4vjprnd>
X-Phabricator-Cc: <PHID-USER-dyyyzfp34mimhzvg33tk>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-i34kfg4qpajia7fo5u5l-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-i34kfg4qpajia7fo5u5l-req@FreeBSD.org>
Thread-Index: ODZhMzNlYThiYzMxOTgzYmRhMDE5M2Q2Yzk4IFYki9w=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2015 06:21:16 -0000

hrs added a subscriber: hrs.
hrs added a comment.

It is true that this LOR is driver-specific but calling SIOCSIFMTU after acquiring a lock in lagg ioctl is not always safe.  Change of lladdr suffers from the same situation and it was solved by using an asynchronous task queue to update addresses on each port.  What do you think about piggybacking an MTU change to the queue by extending struct lagg_llq to a more generic one which makes it possible to handle per-port properties?


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1986

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: rpokala-panasas.com, rstone
Cc: hrs, sbruno, lakshmi.n_msystechnologies.com, emaste, ae, freebsd-net-list