From owner-svn-src-all@freebsd.org Tue Dec 20 02:14:48 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8C91C899A1; Tue, 20 Dec 2016 02:14:48 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x243.google.com (mail-ua0-x243.google.com [IPv6:2607:f8b0:400c:c08::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 78BA9B88; Tue, 20 Dec 2016 02:14:48 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x243.google.com with SMTP id 50so13572104uae.2; Mon, 19 Dec 2016 18:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=speRyE2gJF0/WqQvHnl52AQ4OvVvkJPKtJ56gEiAG5o=; b=RlJ7igaelU7VNRg+WejkBEhH4gdnkOaWxQk1R57lMpBigYTRdbx4vfboSSPLV1u+0j hPXeld5HHvzuPRAA7sXiW6HTi5n+f7JHD6WES5w8d+Emy5qnoscJSSnMsSZxeBmJt5z2 J8m486pmPPyy6Y1Pn8A23QNqVFi+YpGu1keiHIoTGQSy6r6wFqZit54c+rQb1n7F/Kq0 dVRgdbKOWwYrD1V7RRIwUmKUHxNpy0WZBPI/+M4iI+MWcuShczPeXc/MMhXorapQhFmy oIXSCEU/oPKfnHJbUbwMYcYyOOrUEfTV4sjSDpHS8blCJkZsoYzu5Qh32v5GIhWRf0Xm 32Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=speRyE2gJF0/WqQvHnl52AQ4OvVvkJPKtJ56gEiAG5o=; b=CVLMBOunnsY4RAq4dpUV3ycYsFQcYx0NrYjj5TyHjEMsk0U5Zf1fTZdMdcb84Mh5dG 62Fa2TLrXflZ+CjqR+yh9f7KRmn07hPbs7tJpBIAJjXQnih7FfFG8/oiOYAbOF4eElPG pYxsgc6tHKW6ZpOkSdd669VyJmnW48pRc0C937ykSWfne8u6BJS8J8mmLXzCKAjvGCeA +lo7CY4XpW+GfQIl8FN9yt8ibBPm0nPqWKuKwUjsZpv/lM1/Uh9eZE6/VHFpvstC/7bm a30AZlyrLwM59JK0FsVAj8NiUQYtyCyIQhuO99GHnO5KqrNr5jv+aS+I0HTMC6dLDlTg hUgA== X-Gm-Message-State: AKaTC03M/fvVBTzr4arUnVjDXjbdZlN1iUc4t9aapv0/JJMw48gUB5dvpRO2mWeFVD3kMHVXVNQ6F+HWhLs9aA== X-Received: by 10.176.68.132 with SMTP id n4mr15257506uan.75.1482200072482; Mon, 19 Dec 2016 18:14:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.2.86 with HTTP; Mon, 19 Dec 2016 18:14:31 -0800 (PST) In-Reply-To: References: <201612161949.uBGJnMol059217@repo.freebsd.org> <9BD5034F-55A6-48F6-A391-A0877FF49702@panasas.com> <1482175209.48539.9.camel@freebsd.org> From: Sepherosa Ziehau Date: Tue, 20 Dec 2016 10:14:31 +0800 Message-ID: Subject: Re: svn commit: r310171 - head/sys/sys To: Ravi Pokala Cc: Ian Lepore , Warner Losh , Dimitry Andric , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 02:14:48 -0000 On Tue, Dec 20, 2016 at 4:37 AM, Ravi Pokala wrote: > -----Original Message----- >> From: on behalf of Ian Lepore >> Date: 2016-12-19, Monday at 11:20 >> To: Warner Losh , Ravi Pokala >> Cc: Sepherosa Ziehau , Dimitry Andric , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" >> Subject: Re: svn commit: r310171 - head/sys/sys >> >> On Mon, 2016-12-19 at 11:58 -0700, Warner Losh wrote: >>> >>> ... >>> >>> Are there other precedence for avoiding the SCN macros in the tree as >>> well, or is this new art? >>> >>> Warner >> >> There was another commit recently the fixed the same kind of scanf >> error by making the variable fit the scanf type (changing uint64_t to >> an explicit long long unsigned, iirc). I don't know if that alone >> counts as a precedent, but IMO it's a more palatible fix than the >> SCN/PRI ugliness. > > With all apologies to Churchill, SCN/PRI are the worst way to address this in a machine-independent way, except for all the other ways that have been tried from time to time. :-P > If no objection comes, I'd commit the posted patch as it is tomorrow in my time. Thanks, sephe -- Tomorrow Will Never Die