From owner-svn-src-all@FreeBSD.ORG Wed Oct 1 20:03:48 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A1DB44CA; Wed, 1 Oct 2014 20:03:48 +0000 (UTC) Received: from mail-ig0-x231.google.com (mail-ig0-x231.google.com [IPv6:2607:f8b0:4001:c05::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 562C7E67; Wed, 1 Oct 2014 20:03:48 +0000 (UTC) Received: by mail-ig0-f177.google.com with SMTP id a13so273769igq.4 for ; Wed, 01 Oct 2014 13:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bHWrNX/I2/GQehfspK1q+ZO/gqJGDXcXR7483ReIbps=; b=YQxp06ZruxgVgOODYuukZTpU291Dm+Q9U2tR+Zr56aRbFTy09gdg2cvy2AktEAWwyv bCWFt/ZiuUg4JeDl0R6U1GfZp8ku1LCY4eVi458Cy1GpO1A+ZhITF8/mKi8Ei6/Td236 ceTAKtYTVA6sGBFAEEvFee+E2vJVsnzx8yiEMds5OP+4/d1qjunkdu75i+CrumJVNS8Q 7QL3ZL9Na1gabjIZlDrbWoLTIKMmdKZXTQ0txht8nL9olq+aCJenqRWKd65ls9OnV9+E Ck+WJ0EADy25GEhYf7Alx1K3n7OWHYRO4klAdF4de2oU0LkLwX+5tysHLu93fbn1hdAs FjzQ== MIME-Version: 1.0 X-Received: by 10.50.44.71 with SMTP id c7mr22533148igm.49.1412193827699; Wed, 01 Oct 2014 13:03:47 -0700 (PDT) Received: by 10.50.227.42 with HTTP; Wed, 1 Oct 2014 13:03:47 -0700 (PDT) In-Reply-To: <201409291505.s8TF5Nhh066884@svn.freebsd.org> References: <201409291505.s8TF5Nhh066884@svn.freebsd.org> Date: Wed, 1 Oct 2014 13:03:47 -0700 Message-ID: Subject: Re: svn commit: r272282 - head/share/mk From: NGie Cooper To: Will Andrews Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2014 20:03:48 -0000 On Mon, Sep 29, 2014 at 8:05 AM, Will Andrews wrote: > Author: will > Date: Mon Sep 29 15:05:23 2014 > New Revision: 272282 > URL: http://svnweb.freebsd.org/changeset/base/272282 > > Log: > Search for the nearest PORTSDIR where Mk/bsd.ports.mk exists, from .CURDIR. > This will only take effect if PORTSDIR is not set, as previously supported. > > Use .if exists(), for four specific possibilities relative to .CURDIR: > ., .., ../.., and ../../.. The fourth possibility is primarily in case > ports ever grows a third level. If none of these paths exist, fall back to > the old default of /usr/ports. > > This removes the need to set PORTSDIR explicitly (or via wrapper script) if > one is running out of a ports tree that is not in /usr/ports, but in a > home directory. > > Reviewed by: bapt, bdrewery (older version) > CR: D799 > MFC after: 1 week > Sponsored by: Spectra Logic > > Modified: > head/share/mk/bsd.port.mk > head/share/mk/bsd.port.subdir.mk This change seems like it introduces a lot of unnecessary complexity in lieu of someone setting PORTSDIR to the root of their ports tree in the environment. Why isn't it using a for-loop by the way? Thanks!