From owner-freebsd-amd64@FreeBSD.ORG  Sat Jan 31 21:13:23 2004
Return-Path: <owner-freebsd-amd64@FreeBSD.ORG>
Delivered-To: freebsd-amd64@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AB1A816A4CE; Sat, 31 Jan 2004 21:13:23 -0800 (PST)
Received: from fed1mtao07.cox.net (fed1mtao07.cox.net [68.6.19.124])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7E83F43D41; Sat, 31 Jan 2004 21:13:22 -0800 (PST)
	(envelope-from xcas@cox.net)
Received: from cox.net ([68.2.134.143]) by fed1mtao07.cox.net
          (InterMail vM.5.01.06.05 201-253-122-130-105-20030824) with ESMTP
          id <20040201051320.EDQA11482.fed1mtao07.cox.net@cox.net>;
          Sun, 1 Feb 2004 00:13:20 -0500
Message-ID: <401C8B3A.6030300@cox.net>
Date: Sat, 31 Jan 2004 22:14:34 -0700
From: "Greg J." <xcas@cox.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Tim Robbins <tjr@freebsd.org>
References: <200401311932.37140.adridg@cs.kun.nl> <401C02A9.5030506@cox.net>
	<20040131205355.GY74366@funkthat.com>
In-Reply-To: <20040131205355.GY74366@funkthat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: Adriaan de Groot <adridg@cs.kun.nl>
cc: John-Mark Gurney <gurney_j@efn.org>
cc: freebsd-amd64@freebsd.org
Subject: Re: msdosfs patch
X-BeenThere: freebsd-amd64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the AMD64 platform <freebsd-amd64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-amd64>
List-Post: <mailto:freebsd-amd64@freebsd.org>
List-Help: <mailto:freebsd-amd64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Feb 2004 05:13:23 -0000

John-Mark Gurney wrote:
> Greg J. wrote this message on Sat, Jan 31, 2004 at 12:31 -0700:
> 
>>>Since Tim didn't mail his patch to the amd64 list, perhaps you could 
>>>re-post it there?
>>
>>oops.. I thought Tim's patch went to the freebsd-amd64 list as well.. 
>>sorry. It's attached to this email. :)
> 
> 
> looks good, though was this (mis)spelling of size_t intentional?
> 
> [...]
> 
>> static u_int16_t unix2doschr(const u_char **, size_t *, struct msdosfsmount *);
> 
> [...]
> 
>>-	int i, j, l;
>>+	ssize_t i, j;
>>+	int l;
>> 	int conv = 1;
>> 	const u_char *cp, *dp, *dp1;
>> 	u_char gentext[6], *wcp;
>>@@ -531,7 +532,7 @@
>> 	 * Filenames with some characters are not allowed!
>> 	 */
>> 	for (cp = un, i = unlen; i > 0;)
>>-		if (unix2doschr(&cp, (size_t *)&i, pmp) == 0)
>>+		if (unix2doschr(&cp, &i, pmp) == 0)
>> 			return 0;
>> 
>> 	/*
> 
> 
I'm no C expert.. but I'm guessin that (ssize_t) is a typo.. funny how 
it still works?