From owner-cvs-all Wed Feb 20 21:10:28 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by hub.freebsd.org (Postfix) with ESMTP id BA13837B41E; Wed, 20 Feb 2002 21:09:53 -0800 (PST) Received: from peter3.wemm.org ([12.232.27.13]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020221050948.IDWN1147.rwcrmhc52.attbi.com@peter3.wemm.org>; Thu, 21 Feb 2002 05:09:48 +0000 Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id g1L59ms43931; Wed, 20 Feb 2002 21:09:48 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id EA79339F1; Wed, 20 Feb 2002 21:09:47 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: John Baldwin Cc: Matthew Dillon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps print.c In-Reply-To: Date: Wed, 20 Feb 2002 21:09:47 -0800 From: Peter Wemm Message-Id: <20020221050947.EA79339F1@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG John Baldwin wrote: > > On 21-Feb-02 Matthew Dillon wrote: > > > >: > >: > >:On 16-Feb-02 Matt Dillon wrote: > >:> dillon 2002/02/16 12:10:00 PST > >:> > >:> Modified files: > >:> bin/ps print.c > >:> Log: > >:> When blocked on a mutex, display the mutex name via the wchan string > >:> field > >:> so we can at least tell the difference between being blocked in Giant > >:> and being blocked in some other mutex. > >: > >:ps -o mtxname > >: > >::) > >: > >:The manpage even documents this. :) > >: > >:-- > >: > >:John Baldwin <>< http://www.FreeBSD.org/~jhb/ > >:"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > > > > It's a lot easier to just have ps axl show it, since the wchan > > field is otherwise unused. Alternatively we could create a > > synthesize field 'mwchan' which replaces the default 'wchan' for > > ps output that does this combo. > > Sounds good to me. I actually did something like this for top. In top I had > all mutex names start with a * to differentiate them from wait channel names, can you do a similar thing for mwchan? Actually, I dont mind either way, but I do very much like the '*' in top, so if anybody puts chans and mutexes in ps output in a single merged field, then please do the same. It's easy to tell that "Giant" is a mutex since it is so recognizable, but what about "tlb"? is that a wchan or a mutex name? Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message