Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Apr 2019 06:03:34 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc:        "Tobias C. Berner" <tcberner@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r500363 - in head/sysutils: . etc_os-release
Message-ID:  <20190430060334.GA97846@FreeBSD.org>
In-Reply-To: <CAMHz58R5y9a1wqw4yQqC6==CN3RstVvWbRao8Q-HcWUh=cfVPA@mail.gmail.com>
References:  <201904281922.x3SJMLo2013472@repo.freebsd.org> <CAMHz58R5y9a1wqw4yQqC6==CN3RstVvWbRao8Q-HcWUh=cfVPA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 30, 2019 at 08:24:15AM +0800, Po-Chuan Hsieh wrote:
> ...
> May I suggest putting all these in a tiny sh script in files directory?
> It would look more clear.

It's fine to be left in the Makefile, but in a better from as suggested
by me earlier.  The last phab iteration had slipped my review somehow.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190430060334.GA97846>