Date: Fri, 19 May 2006 09:09:56 +0200 From: Jean-Yves Lefort <jylefort@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/print/acroread7 Makefile pkg-deinstall pkg-plist.7.0.1 pkg-plist.7.0.5 ports/print/acroread7/files pkg-install.in Message-ID: <20060519090956.4f19dd41.jylefort@FreeBSD.org> In-Reply-To: <20060519.154122.123975929.hrs@allbsd.org> References: <20060519073710.2a3a1839.jylefort@FreeBSD.org> <20060519.145305.91317084.hrs@allbsd.org> <20060519075844.e1ac8d3b.jylefort@FreeBSD.org> <20060519.154122.123975929.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Fri__19_May_2006_09_09_56_+0200_roGWylOJTwf=I9oy Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 19 May 2006 15:41:22 +0900 (JST) Hiroki Sato <hrs@FreeBSD.org> wrote: > Jean-Yves Lefort <jylefort@FreeBSD.org> wrote > in <20060519075844.e1ac8d3b.jylefort@FreeBSD.org>: >=20 > jy> On Fri, 19 May 2006 14:53:05 +0900 (JST) > jy> Hiroki Sato <hrs@FreeBSD.org> wrote: > jy> > jy> > Jean-Yves Lefort <jylefort@FreeBSD.org> wrote > jy> > in <20060519073710.2a3a1839.jylefort@FreeBSD.org>: > jy> > > jy> > jy> On Fri, 19 May 2006 14:27:45 +0900 (JST) > jy> > jy> Hiroki Sato <hrs@FreeBSD.org> wrote: > jy> > jy> > jy> > jy> > Jean-Yves Lefort <jylefort@FreeBSD.org> wrote > jy> > jy> > in <200605190513.k4J5DxTq063125@repoman.freebsd.org>: > jy> > jy> > > jy> > jy> > jy> jylefort 2006-05-19 05:13:59 UTC > jy> > jy> > jy> > jy> > jy> > jy> FreeBSD ports repository > jy> > jy> > jy> > jy> > jy> > jy> Modified files: > jy> > jy> > jy> print/acroread7 Makefile pkg-plist.7.0.1 pkg-pli= st.7.0.5 > jy> > jy> > jy> Added files: > jy> > jy> > jy> print/acroread7 pkg-deinstall > jy> > jy> > jy> print/acroread7/files pkg-install.in > jy> > jy> > jy> Log: > jy> > jy> > jy> - Fix packing list > jy> > jy> > jy> - Install a desktop entry > jy> > jy> > jy> > jy> > jy> > jy> PR: ports/96642 > jy> > jy> > jy> Submitted by: jylefort > jy> > jy> > jy> Approved by: maintainer timeout (17 days) > jy> > jy> > > jy> > jy> > This commit prevents multiple localized acroread ports > jy> > jy> > from working with each other in a system > jy> > jy> > jy> > jy> ? > jy> > > jy> > So, please explain how the pkg-install/pkg-deinstall scripts work > jy> > when we install a number of localized acroread ports in a system. > jy> > jy> It was explained in the PR... > jy> > jy> "Notes: > jy> - slave ports handling: the desktop entry and icon are installed > jy> when the first acroread port is installed, and deinstalled when t= he > jy> last acroread port is deinstalled" >=20 > Your patch assumes removal of Adobe/Acrobat7.0 on deinstalling. It only > happens when print/acroreadwrapper is deinstalled. >=20 > Also, I do not like this sort of change because the license (2.5, > specifically) does not allow creating another installer and > modifying the installed files. Because of this, I make this port > simply call the installer from Adobe. With that interpretation the port is also illegal since it's not only a "new installer", but also "modifies the Software" (through brandelf, for instance): "You may not otherwise alter or modify the Software or create a new installer for the Software." Can I fix pkg-deinstall by checking if $PKG_PREFIX/Adobe/Acrobat7.0 is empty after deinstallation? --=20 Jean-Yves Lefort jylefort@FreeBSD.org http://lefort.be.eu.org/ --Signature=_Fri__19_May_2006_09_09_56_+0200_roGWylOJTwf=I9oy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEbW9EyzD7UaO4AGoRAh0bAJ9eWUw3erG+/YLixE6ogqlMJGlHTACfdtrN zE8CIlPItxHtp/XWczs1mnA= =w//h -----END PGP SIGNATURE----- --Signature=_Fri__19_May_2006_09_09_56_+0200_roGWylOJTwf=I9oy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060519090956.4f19dd41.jylefort>