From owner-svn-src-all@FreeBSD.ORG Sun Mar 1 14:27:55 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 20A9B106566C; Sun, 1 Mar 2009 14:27:55 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129]) by mx1.freebsd.org (Postfix) with ESMTP id D45AC8FC40; Sun, 1 Mar 2009 14:27:54 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 823B073098; Sun, 1 Mar 2009 15:32:50 +0100 (CET) Date: Sun, 1 Mar 2009 15:32:50 +0100 From: Luigi Rizzo To: Robert Watson Message-ID: <20090301143250.GA57294@onelab2.iet.unipi.it> References: <200903011242.n21CgsV1043573@svn.freebsd.org> <20090301132350.GB54337@onelab2.iet.unipi.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189230 - head/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2009 14:27:56 -0000 On Sun, Mar 01, 2009 at 01:33:49PM +0000, Robert Watson wrote: > On Sun, 1 Mar 2009, Luigi Rizzo wrote: ... > >any chance to do similar things for other key kernel structures, such as > >mbufs and struct bio ? > > > >As an example, "struct bio" would benefit from at least one extra intptr_t > >field to be used for classification purposes (see some recent work we have > >been doing on disk scheduling). This is a rather trivial and unintrusive > >change. > > > >struct mbuf would benefit from a 'length' field, replacing the hardcoded > >MLEN/MHLEN. This field would allow us to do several things, e.g.: > > Jeff has a large work-in-progress on mbufs, and so I don't want to go near > that until all that work has shaken out. This includes support for > variable-size mbufs and eliminating large amounts of cluster use (while > retaining support for external storage, a we require that for zero-copy > foo). If you haven't seen his posts about that work, you might want to give > them a skim -- I think they were on arch@/net@. ok thanks -- i did not see the posts but the things you explain are perfectly in sync with what I had in mind. > I thought bio was less sensitive to change since it was centrally allocated > these days, or is that not the case? you are probably right, probably it's just the case to add the field at the end so binary geom modules will not be affected by the change. cheers luigi