From owner-svn-src-head@FreeBSD.ORG  Sun Apr 27 21:22:49 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id DD75B283;
 Sun, 27 Apr 2014 21:22:49 +0000 (UTC)
Received: from mail.ipfw.ru (mail.ipfw.ru [IPv6:2a01:4f8:120:6141::2])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9F48319D;
 Sun, 27 Apr 2014 21:22:49 +0000 (UTC)
Received: from secured.by.ipfw.ru ([95.143.220.47] helo=ws.su29.net)
 by mail.ipfw.ru with esmtpsa (TLSv1:AES128-SHA:128)
 (Exim 4.76 (FreeBSD)) (envelope-from <melifaro@FreeBSD.org>)
 id 1WeSdg-000AB9-R6; Sun, 27 Apr 2014 21:13:16 +0400
Message-ID: <535D7500.9020808@FreeBSD.org>
Date: Mon, 28 Apr 2014 01:22:08 +0400
From: "Alexander V. Chernikov" <melifaro@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Ian Lepore <ian@FreeBSD.org>
Subject: Re: svn commit: r265019 - head/sys/net
References: <201404271741.s3RHfIYF058370@svn.freebsd.org>
 <1398632453.61646.182.camel@revolution.hippie.lan>
In-Reply-To: <1398632453.61646.182.camel@revolution.hippie.lan>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Apr 2014 21:22:49 -0000

On 28.04.2014 01:00, Ian Lepore wrote:
> On Sun, 2014-04-27 at 17:41 +0000, Alexander V. Chernikov wrote:
>> Author: melifaro
>> Date: Sun Apr 27 17:41:18 2014
>> New Revision: 265019
>> URL: http://svnweb.freebsd.org/changeset/base/265019
>>
>> Log:
>>   Improve memory allocation model for rt_msg2() rtsock messages:
>>    * memory is now allocated as early as possible, without holding locks.
>>    * sysctl users are now guaranteed to get a response (M_WAITOK buffer prealloc).
>>    * socket users are more likely to use on-stack buffer for replies.
>>    * standard kernel malloc/free functions are now used instead of radix wrappers.
>>   rt_msg2() has been renamed to rtsock_msg_buffer().
>>   
>>   MFC after:	1 month
>>
>> Modified:
>>   head/sys/net/rtsock.c
>>
>> Modified: head/sys/net/rtsock.c
>> [...]
> 
> You're on a roll this weekend. :)  I got another uninit-var warning
> today -- I worked around it with this, but I'm not sure it's the right
> way to fix it:
Fixed. Thanks again.
It looks like something wrong has happened to my clang setup..
> 
> revolution > sd sys/net/rtsock.c
> Index: sys/net/rtsock.c
> ===================================================================
> --- sys/net/rtsock.c	(revision 265026)
> +++ sys/net/rtsock.c	(working copy)
> @@ -1132,7 +1132,8 @@ rtsock_msg_buffer(int type, struct rt_addrinfo *rt
>  		rtm = (struct rt_msghdr *)w->w_tmem;
>  		buflen = w->w_tmemsize - len;
>  		cp = (caddr_t)w->w_tmem + len;
> -	}
> +	} else
> +		cp = NULL;
>  
>  	rtinfo->rti_addrs = 0;
>  	for (i = 0; i < RTAX_MAX; i++) {
> 
> 
> -- Ian
> 
> 
>