From owner-freebsd-audit Thu Sep 13 14:51:53 2001 Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.162.213]) by hub.freebsd.org (Postfix) with ESMTP id D1BBE37B406 for ; Thu, 13 Sep 2001 14:51:49 -0700 (PDT) Received: from dagger.cc.vt.edu (IDENT:mirapoint@dagger.cc.vt.edu [198.82.161.182]) by lennier.cc.vt.edu (8.11.4/8.11.4) with ESMTP id f8DLpmE484488; Thu, 13 Sep 2001 17:51:48 -0400 (EDT) Received: from enterprise.muriel.penguinpowered.com (hc652647d.dhcp.vt.edu [198.82.100.125]) by dagger.cc.vt.edu (Mirapoint) with ESMTP id AEU00924; Thu, 13 Sep 2001 17:46:33 -0400 (EDT) Message-ID: X-Mailer: XFMail 1.5.0 on FreeBSD X-Priority: 3 (Normal) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="_=XFMail.1.5.0.FreeBSD:20010913174400:420=_"; micalg=pgp-md5; protocol="application/pgp-signature" In-Reply-To: <20010913130145.L1855@basm.cerias.purdue.edu> Date: Thu, 13 Sep 2001 17:44:00 -0400 (EDT) From: Mike Heffner To: Brian Poole Subject: RE: Cleanup in adduser.perl Cc: freebsd-audit@FreeBSD.ORG Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This message is in MIME format --_=XFMail.1.5.0.FreeBSD:20010913174400:420=_ Content-Type: text/plain; charset=us-ascii On 13-Sep-2001 Brian Poole wrote: | Hello, | | Cleaned up many similar problems in OpenBSD's adduser which was | originally from Free, decided to mirror the changes where | possible in FreeBSD's adduser. This patch hasn't been tested, | but the changes are all relatively minor and should be correct. | | If someone could review & possibly commit, would be appreciated. | It looks pretty good, however I'm not too Perl knowledgeable, so I can't say for sure. While on the subject of adduser, I've had the following similar patch to a local admin script here for awhile. The patch adds '.' and '/' to the salt string, and makes it match that in src/usr.bin/passwd/local_passwd.c and crypt(3). Is there any negative effect of the following? Index: adduser.perl =================================================================== RCS file: /home/ncvs/src/usr.sbin/adduser/adduser.perl,v retrieving revision 1.49 diff -u -r1.49 adduser.perl --- adduser.perl 2001/09/06 12:21:21 1.49 +++ adduser.perl 2001/09/13 21:33:35 @@ -891,7 +891,7 @@ sub salt { local($salt); # initialization local($i, $rand); - local(@itoa64) = ( '0' .. '9', 'a' .. 'z', 'A' .. 'Z' ); # 0 .. 63 + local(@itoa64) = ( '.', '/', '0' .. '9', 'A' .. 'Z', 'a' .. 'z' ); # 0..63 warn "calculate salt\n" if $verbose > 1; # to64 Mike -- Mike Heffner Blacksburg, VA --_=XFMail.1.5.0.FreeBSD:20010913174400:420=_ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7oSifFokZQs3sv5kRAuqqAJ0WqQBjdYYdCRi57FbV94drziZL2gCfbTTe 880JVWfV/ZVJc5GABJJKWlI= =Ve8u -----END PGP SIGNATURE----- --_=XFMail.1.5.0.FreeBSD:20010913174400:420=_-- End of MIME message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message