From nobody Mon Jun 1 18:30:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gTjF7041Bz6gVFZ for ; Mon, 01 Jun 2026 18:30:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gTjF61VBHz3Cbh for ; Mon, 01 Jun 2026 18:30:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780338618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ynGc7VignvQmJoix+aHmHCGCOkqYpryCdSJjOEtZ//c=; b=dCh4q88v1NaRtx9HTkTXl/p2pxsBV7u8RL7YSMgz+H5y8r1HiAoF2feUjiVXwEvaGVETZF LAAPdnZLG+8BkgIiPXlhH4p+vgyGopZzI2jSXtG7CF2RNQzvJjR/SRF81+jrXCo0ysO2TY 2LEun9h7dEEyz4QCJvVHnGYM3FOQIw1/kF2385gfaD+qBlBpqgbv0EPKnWtPr6YiJi1TiM 0VLWZs5XQQ30bd5CGxb0+zVDzXYFHAlRt07aCbDCW92W9NjVdESpvGl2c3QIu3XrPK6K+/ RcD6SySCmwuWsQo3ZPhBjfX9LJKXGNbLxOoMjoTjbupaFPtWSqhnecoxUb2CZg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780338618; a=rsa-sha256; cv=none; b=dJZBPBVaFH49i9UCSV5tsencSHKZ6JQ4vijiVooXGsdzQKJrS1B2nyXxUMMWMSJsXBVFAK 4W/q6Xh90fZtzZ7PyF5WLztlBf6GxIRAmPM12jnM15eiTDoJlYv9OLnJm7VaoaLU1R0Rwt w3Vw94myZWkdDdgev71eLgRM3Q5ajb6Gp3MDI9qsF7pC5ow+Kpe4/Rji1LDB97XIUL0+so A16BVUxA5ZezfaxEJ82cWEc7RpL1TQRxBAx6eR4yQWLrHRdFaKCDpSxmK/DIwKvp6rK3B4 QMpHc6TNEMNnbLEKUV8MWnBmRzCsNYNLdSW+DjxwC2rhaD+vOJNljqkm7qh3BA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780338618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ynGc7VignvQmJoix+aHmHCGCOkqYpryCdSJjOEtZ//c=; b=Y7+Ub1w5tiAKq4GgmfgQGwnCNq2RZQlywfn/DK9KNDtGmV6b3UV2yi6W/JvSx+6vM9/3V2 yWjrQNIGfCc5bye6CuHqoRlG65v84dU3qo4/iA70RACsP/JydsYnEBiMDf0wj94fhKguMy K/2+cl/bCyVxLEgTDYGfSKjB6cSfv/6an179tl+emSpBlTouo9HYoi7HLMCJLcbfvenNqy sduNSJOHiYHKGnx3ZRBO/SCYmc8PXFWwq3lR+AVUjxRu8ta55CYu/HmIFvoalPDmW9VYF3 zTQGOLV+1H7pQ/Ne5sR/etfOzrKFe7OS6hAiXR+Bhdtobp26FMXcXnoViBgVkQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gTjF60RFlzqMV for ; Mon, 01 Jun 2026 18:30:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 204d2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 01 Jun 2026 18:30:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 49d90d9ddfc1 - main - lagg: Handle a port count of zero List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 49d90d9ddfc1ecda9ad9b6cb5565e5fbdcc14964 Auto-Submitted: auto-generated Date: Mon, 01 Jun 2026 18:30:13 +0000 Message-Id: <6a1dcfb5.204d2.42e2225a@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=49d90d9ddfc1ecda9ad9b6cb5565e5fbdcc14964 commit 49d90d9ddfc1ecda9ad9b6cb5565e5fbdcc14964 Author: Mark Johnston AuthorDate: 2026-06-01 16:40:43 +0000 Commit: Mark Johnston CommitDate: 2026-06-01 18:22:57 +0000 lagg: Handle a port count of zero The sc_count check in lagg_transmit_ethernet() and lagg_transmit_infiniband() is racy, as the lagg protocol handlers are only synchronized by net_epoch. Handle a count of 0 in each protocol handler where it's needed, namely in the RR and LB handlers. Reported by: Yuxiang Yang, Yizhou Zhao, Xuewei Feng, Qi Li, and Ke Xu from Tsinghua University using GLM5.1 from Z.ai Reviewed by: pouria, zlei MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D56942 --- sys/net/if_lagg.c | 40 +++++++++++++++++++++++----------------- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/sys/net/if_lagg.c b/sys/net/if_lagg.c index 0333162da0d4..da08e02d50be 100644 --- a/sys/net/if_lagg.c +++ b/sys/net/if_lagg.c @@ -1828,6 +1828,7 @@ lookup_snd_tag_port(struct ifnet *ifp, uint32_t flowid, uint32_t flowtype, struct lagg_port *lp; struct lagg_lb *lb; uint32_t hash, p; + unsigned int count; int err; sc = ifp->if_softc; @@ -1839,8 +1840,11 @@ lookup_snd_tag_port(struct ifnet *ifp, uint32_t flowid, uint32_t flowtype, if ((sc->sc_opts & LAGG_OPT_USE_FLOWID) == 0 || flowtype == M_HASHTYPE_NONE) return (NULL); + count = atomic_load_int(&sc->sc_count); + if (count == 0) + return (NULL); p = flowid >> sc->flowid_shift; - p %= sc->sc_count; + p %= count; lb = (struct lagg_lb *)sc->sc_psc; lp = lb->lb_ports[p]; return (lagg_link_active(sc, lp)); @@ -2128,12 +2132,6 @@ lagg_transmit_ethernet(struct ifnet *ifp, struct mbuf *m) if (m->m_pkthdr.csum_flags & CSUM_SND_TAG) MPASS(m->m_pkthdr.snd_tag->ifp == ifp); #endif - /* We need at least one port */ - if (sc->sc_count == 0) { - m_freem(m); - if_inc_counter(ifp, IFCOUNTER_OERRORS, 1); - return (ENXIO); - } ETHER_BPF_MTAP(ifp, m); @@ -2150,12 +2148,6 @@ lagg_transmit_infiniband(struct ifnet *ifp, struct mbuf *m) if (m->m_pkthdr.csum_flags & CSUM_SND_TAG) MPASS(m->m_pkthdr.snd_tag->ifp == ifp); #endif - /* We need at least one port */ - if (sc->sc_count == 0) { - m_freem(m); - if_inc_counter(ifp, IFCOUNTER_OERRORS, 1); - return (ENXIO); - } infiniband_bpf_mtap(ifp, m); @@ -2421,13 +2413,20 @@ lagg_rr_start(struct lagg_softc *sc, struct mbuf *m) { struct lagg_port *lp; uint32_t p; + unsigned int count; + count = atomic_load_int(&sc->sc_count); + if (__predict_false(count == 0)) { + if_inc_counter(sc->sc_ifp, IFCOUNTER_OERRORS, 1); + m_freem(m); + return (ENETDOWN); + } p = atomic_fetchadd_32(&sc->sc_seq, 1); p /= sc->sc_stride; - p %= sc->sc_count; - lp = CK_SLIST_FIRST(&sc->sc_ports); + p %= count; - while (p--) + lp = CK_SLIST_FIRST(&sc->sc_ports); + while (p-- && lp != NULL) lp = CK_SLIST_NEXT(lp, lp_entries); /* @@ -2611,13 +2610,20 @@ lagg_lb_start(struct lagg_softc *sc, struct mbuf *m) struct lagg_lb *lb = (struct lagg_lb *)sc->sc_psc; struct lagg_port *lp = NULL; uint32_t p = 0; + unsigned int count; + count = atomic_load_int(&sc->sc_count); + if (__predict_false(count == 0)) { + if_inc_counter(sc->sc_ifp, IFCOUNTER_OERRORS, 1); + m_freem(m); + return (ENETDOWN); + } if ((sc->sc_opts & LAGG_OPT_USE_FLOWID) && M_HASHTYPE_GET(m) != M_HASHTYPE_NONE) p = m->m_pkthdr.flowid >> sc->flowid_shift; else p = m_ether_tcpip_hash(sc->sc_flags, m, lb->lb_key); - p %= sc->sc_count; + p %= count; lp = lb->lb_ports[p]; /*