From owner-svn-src-all@FreeBSD.ORG Fri May 24 06:52:54 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 1767DC97; Fri, 24 May 2013 06:52:54 +0000 (UTC) (envelope-from tuexen@fh-muenster.de) Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) by mx1.freebsd.org (Postfix) with ESMTP id CF9F990; Fri, 24 May 2013 06:52:53 +0000 (UTC) Received: from [192.168.1.200] (p508F0DA0.dip0.t-ipconnect.de [80.143.13.160]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTP id C0F6A1C0B384B; Fri, 24 May 2013 08:52:52 +0200 (CEST) Subject: Re: svn commit: r250809 - head/sys/netinet Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Michael Tuexen In-Reply-To: Date: Fri, 24 May 2013 08:52:55 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201305191606.r4JG6hNR032154@svn.freebsd.org> To: "Bjoern A. Zeeb" X-Mailer: Apple Mail (2.1283) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 May 2013 06:52:54 -0000 On May 24, 2013, at 8:50 AM, Michael Tuexen wrote: > On May 23, 2013, at 11:37 PM, Bjoern A. Zeeb wrote: >=20 >> On Sun, 19 May 2013, Michael Tuexen wrote: >>=20 >>> Author: tuexen >>> Date: Sun May 19 16:06:43 2013 >>> New Revision: 250809 >>> URL: http://svnweb.freebsd.org/changeset/base/250809 >>>=20 >>> Log: >>> Initialize the fibnum for outgoing packets to 0. This avoids >>> crashing due to the usage of uninitialized fibnum. >>> This bugs became visiable after >>> http://svnweb.freebsd.org/changeset/base/250700 >>=20 >>=20 >> That just masks the real bug, please back it out. > And the real bug is that SCTP doesn't support multiple fibs, right? > That would mean the system crashes on reception of an out of the blue > SCTP packet... OK. I just saw http://svnweb.freebsd.org/changeset/base/250952 I'll back out http://svnweb.freebsd.org/changeset/base/250809 later today. Best regards Michael >=20 > Best regards > Michael >>=20 >>=20 >>> MFC after: 2 weeks >>>=20 >>> Modified: >>> head/sys/netinet/sctp_os_bsd.h >>>=20 >>> Modified: head/sys/netinet/sctp_os_bsd.h >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/netinet/sctp_os_bsd.h Sun May 19 15:26:15 2013 = (r250808) >>> +++ head/sys/netinet/sctp_os_bsd.h Sun May 19 16:06:43 2013 = (r250809) >>> @@ -435,6 +435,7 @@ typedef struct rtentry sctp_rtentry_t; >>> { \ >>> int o_flgs =3D IP_RAWOUTPUT; \ >>> struct sctp_tcb *local_stcb =3D stcb; \ >>> + M_SETFIB(o_pak, 0); \ >>> if (local_stcb && \ >>> local_stcb->sctp_ep && \ >>> local_stcb->sctp_ep->sctp_socket) \ >>> @@ -445,6 +446,7 @@ typedef struct rtentry sctp_rtentry_t; >>> #define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \ >>> { \ >>> struct sctp_tcb *local_stcb =3D stcb; \ >>> + M_SETFIB(o_pak, 0); \ >>> if (local_stcb && local_stcb->sctp_ep) \ >>> result =3D ip6_output(o_pak, \ >>> ((struct in6pcb = *)(local_stcb->sctp_ep))->in6p_outputopts, \ >>>=20 >>=20 >> --=20 >> Bjoern A. Zeeb ????????? ??? ??????? = ??????: >> '??? ??? ???? ?????? ??????? ?? ?? ??????? ??????? ??? ????? ????? = ???? >> ?????? ?? ????? ????', ????????? ?????????, "??? ????? ?? ?????", = ?.??? >>=20 >=20 >=20