Date: Tue, 11 Mar 2014 15:34:43 +0200 From: Alex Kozlov <spam@rm-rf.kiev.ua> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r347857 - head/mail/thunderbird-dictionaries Message-ID: <20140311133443.GA26313@ravenloft.kiev.ua> In-Reply-To: <7E2CA333BD6C7A70FD270041@atuin.in.mat.cc> References: <201403110640.s2B6eMDI022100@svn.freebsd.org> <20140311090000.GB78846@FreeBSD.org> <7E2CA333BD6C7A70FD270041@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 11, 2014 at 10:10:43AM +0100, Mathieu Arnold wrote:
> +--On 11 mars 2014 09:00:00 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
> wrote:
> | The way it's done now generates lots of needless mail traffic and repo
> | churn. It would also be nice if you could provide some details in the
> | commit logs WRT what's exactly is/was broken. Thank you,
>
> Well, what was broken is simple, libarchive can't process the zip file from
> the distfiles, and the port needs to use the unzip command.
I think that in some (many?) cases problem is not in libarchive, but is in
the difference between tar and unzip. E.g for this port:
Index: mail/thunderbird-dictionaries/Makefile
@@ -15,7 +15,7 @@
RUN_DEPENDS= thunderbird>=6.0:${PORTSDIR}/mail/thunderbird
-USES= zip:infozip
+USES= zip
NO_BUILD= yes
WRKSRC= ${WRKDIR}/dictionaries
@@ -58,7 +58,8 @@
@${MKDIR} ${WRKSRC}
.for f in ${ALLDICTS}
.if ${PORT_OPTIONS:M${f}}
- @${UNZIP_CMD} -q ${DISTDIR}/${DIST_SUBDIR}/${${f}_FILE} -d ${WRKSRC}/${${f}_FILE}
+ @${MKDIR} ${WRKSRC}/${${f}_FILE}
+ @${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${DISTDIR}/${DIST_SUBDIR}/${${f}_FILE} -C ${WRKSRC}/${${f}_FILE}
.endif
.endfor
--
Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140311133443.GA26313>