From owner-svn-src-all@freebsd.org Wed Dec 18 16:54:01 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB7451E3258; Wed, 18 Dec 2019 16:54:01 +0000 (UTC) (envelope-from lists@yamagi.org) Received: from mail1.yamagi.org (mail1.yamagi.org [IPv6:2001:19f0:b001:853::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47dLgr4CPBz4nNv; Wed, 18 Dec 2019 16:54:00 +0000 (UTC) (envelope-from lists@yamagi.org) Received: from [2001:470:6845:1:bc89:e268:2ad5:517c] (helo=killua.home.yamagi.org) by mail1.yamagi.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1ihca8-0002uP-VT; Wed, 18 Dec 2019 17:53:54 +0100 Date: Wed, 18 Dec 2019 17:53:41 +0100 From: Yamagi To: vmaffione@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355301 - head/usr.sbin/bhyve Message-Id: <20191218175341.214724de595423ecfe528dff@yamagi.org> In-Reply-To: <201912022051.xB2Kplot078056@repo.freebsd.org> References: <201912022051.xB2Kplot078056@repo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA256"; boundary="Signature=_Wed__18_Dec_2019_17_53_41_+0100_DAj1qso_aVhziwSm" X-Rspamd-Queue-Id: 47dLgr4CPBz4nNv X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of lists@yamagi.org designates 2001:19f0:b001:853::3 as permitted sender) smtp.mailfrom=lists@yamagi.org X-Spamd-Result: default: False [-4.33 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[yamagi.org]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-0.43)[asn: 20473(-2.12), country: US(-0.05)]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:20473, ipnet:2001:19f0:b000::/38, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Dec 2019 16:54:01 -0000 --Signature=_Wed__18_Dec_2019_17_53_41_+0100_DAj1qso_aVhziwSm Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, the change to the defintion of 'const char *vbuf' in rfb.c is wrong. The protocol version string must be send as "RFB 003.008\n" and not as "RFB 003.008\n\r", otherwise the VNC client isn't able to complete the handshake (it doesn't recognize the protocol version). While it stays connected, it doesn't show anything. This patch fixes it for me: diff --git a/usr.sbin/bhyve/rfb.c b/usr.sbin/bhyve/rfb.c index b8fe6e3137d..9c8c6eb0764 100644 --- a/usr.sbin/bhyve/rfb.c +++ b/usr.sbin/bhyve/rfb.c @@ -744,7 +744,7 @@ rfb_wr_thr(void *arg) void rfb_handle(struct rfb_softc *rc, int cfd) { - const char *vbuf =3D "RFB 003.008\n\r"; + const char *vbuf =3D "RFB 003.008\n"; unsigned char buf[80]; unsigned char *message =3D NULL; Regards, Yamagi On Mon, 2 Dec 2019 20:51:47 +0000 (UTC) Vincenzo Maffione wrote: > Author: vmaffione > Date: Mon Dec 2 20:51:46 2019 > New Revision: 355301 > URL: https://svnweb.freebsd.org/changeset/base/355301 >=20 > Log: > bhyve: uniform printf format string newlines > =20 > Some of the printf statements only use LF to get a newline. However, a = CR character is also required for the serial console to print debug logs in= a nice way. > Fix those code locations that only use LF, by adding a CR character. > =20 > Reviewed by: markj, aleksandr.fedorov@itglobal.com > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D22552 --Signature=_Wed__18_Dec_2019_17_53_41_+0100_DAj1qso_aVhziwSm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEOXu/lxyufwz0gC5x6xRy5x1QJRUFAl36WZUACgkQ6xRy5x1Q JRW4mQ/+MKlZap5WgUc4GhNf/DGfXLkOTRcf+/DjQhLjSTjW4lu9QLA70yuQMkTu QaLqrMWX5L6xdYLWuBNtrAglaC5ECJJHnEcXB17JpQgUn/cLFmjqDYdaznjc/X7S 7GvTPu7rgWk1kz7sASGEjsW+4UgU0iFVPBZYUVJvc5YJKvNfAf3EcV5vIjEXjouS GM5juH1llHl3dAQU4eHwI8DRieJGvp37irLz/JKJrb/i5rtMoGVB74SM4jfOk/7d zf6F2yketl0Ct5spq2vhr46URzaUeOBnTMIdnUPQycJjSbw8Oq+j9VTOyeN7YKJ8 UJHBYhg+HzrF7J0Jc/45fi3Y6yNh7KYvPxeu051ZKKHwg5ZabbpRjVUvfpcrEXTM z4F0lhOBsII/HA/9G5kiJMCrk4Im/2K1vg6vNGdNSYzengBZi4/wlqUwKLe5luMY 6PAjTZCKr2/3z4CHcZJLlfh3hv7UvPVZ2a6wI2VBD+GHOgJdIpzK9HZYvXFs5N0+ KS/ThrB2dDK+3KpbbOffk5FFmvpVEMtMkyzzC+OQVl1EZ6hqhcFxrHeolYrUp4oU GhC+oKFRx8Iic/XUIkiPh43mTGOEmFG83RsQ94L5ZxIgRkbYdASwtsczB7NHO3yn n5X3HM5TYy+pE9QbY8qyuu1pcSTvXCtW8dejBOe5YcJCtnaPKBE= =X39R -----END PGP SIGNATURE----- --Signature=_Wed__18_Dec_2019_17_53_41_+0100_DAj1qso_aVhziwSm--