From nobody Thu Sep 29 08:46:04 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MdRlx1Dffz4V8S8; Thu, 29 Sep 2022 08:46:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MdRlx0TbJz3GNM; Thu, 29 Sep 2022 08:46:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664441165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rw0AlMwhKkfeUXOduAEetgJtZrQVjCnvVXlg/hPMjtI=; b=WUSpE2XX2CsSnxFIY1+T9cUyWjJIW2ybLMij1SasvuSEjgKZageWIlS905hM0Vd7DN28+E HKoBPkKuJx0QeqfaGJf6C+gq2zhElvi02aCzn4AD9uGpaTf7OqhSVHJkZb4CbkcXsa0kof wLIIdJO5ntTYg7zDAIm/lMl2eB4PtkJpkuCBDgKQsrYqi4oLID3SZLmEvpjpuOo8KkCfHz OtrqgzGM54YnNXq6JstmleLsmvXBr3UIS6cqCya3aycBlf048bsdBPUjUPOFlV6lFwQQ5B ai3F2O1W990y/ucprEmrFm28v5OW7vTA15w+qYXrVV7+Yx36RI0+nbclHW6G7g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MdRlw6Pv8zm83; Thu, 29 Sep 2022 08:46:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28T8k468005212; Thu, 29 Sep 2022 08:46:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28T8k4Mh005211; Thu, 29 Sep 2022 08:46:04 GMT (envelope-from git) Date: Thu, 29 Sep 2022 08:46:04 GMT Message-Id: <202209290846.28T8k4Mh005211@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kirk McKusick Subject: git: 221da3e9212d - main - Fix an incorrectly placed parenthesis. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mckusick X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 221da3e9212d4cc1e370721493922de232fe3918 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664441165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rw0AlMwhKkfeUXOduAEetgJtZrQVjCnvVXlg/hPMjtI=; b=cIkIGBhVb27Prkcoosxa+uq/KiOGWJ0qIU0mnxaIS7j6gc2b+En0fQNxOmNwwMpuOEXnO6 gObXo1r/+p3Qma3rZ485yPySzjB9ZbFgNr5QeqVfQ77duIl4VcF/G+3Wr+9D4iIIR3gXlB fYzewBfdzDDFPG28dpVM9ydzurcj4aEFXpqkfqMWqUznirQkAv7pbH5ie3de2EQB7BIQki lHOldSZAIKZUurHorQ/fmw+jZcpukcJErmt0l9TeZ05kPgHMIx4sfBsY22tsF15S1J2pV6 iVBVKRn9fLU/ubadgrXFv7AiSL1IbrIHs5H/r84pykFhhUGPdtEHP7TDyZa97w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664441165; a=rsa-sha256; cv=none; b=uXdiQvNiyybVJtz6rFAc0CS5DSlJWhYJ/itT0WnkMSGal5WersSQ+Eo8/ErWEZFRHAxq82 /UvcHg1S74UEWOmjQp2Ev6cs9d81PXLzrbabuv9agHQ7/Du9wIsf4fASYE8sZHkrDgErpr 3rmiodUeLBJsEh5Ij/Fm0aBCfsU+H4Dc/6R9MoKjI+ArGd5+vTBpjsnsOw11WWjHEGeDVB 8+XQyLLvzQOer5IWjBf2/91tSsCbFROi8G0TUeoBtnUJ17I0zT36lbXZPo1pyy2LrH42EO rEy2IZVIKTF53olsEvhgBUM34RhZsrdwUw/DjjVyYrGhajEoph+XHnbAoZsKrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mckusick: URL: https://cgit.FreeBSD.org/src/commit/?id=221da3e9212d4cc1e370721493922de232fe3918 commit 221da3e9212d4cc1e370721493922de232fe3918 Author: Kirk McKusick AuthorDate: 2022-09-29 08:44:34 +0000 Commit: Kirk McKusick CommitDate: 2022-09-29 08:45:41 +0000 Fix an incorrectly placed parenthesis. While syntactically correct and even looking correct, it was definitely not providing the desired result. And it has been this way for nearly twenty years. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation --- sys/ufs/ffs/ffs_snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index 84983a111fe4..bcdf94a10cda 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -689,7 +689,7 @@ loop: *blkp++ = lblkno(fs, fs->fs_sblockloc); blkno = fragstoblks(fs, fs->fs_csaddr); for (cg = 0; cg < fs->fs_ncg; cg++) { - if (fragstoblks(fs, cgtod(fs, cg) > blkno)) + if (fragstoblks(fs, cgtod(fs, cg)) > blkno) break; *blkp++ = fragstoblks(fs, cgtod(fs, cg)); }