Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Sep 2022 08:46:04 GMT
From:      Kirk McKusick <mckusick@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 221da3e9212d - main - Fix an incorrectly placed parenthesis.
Message-ID:  <202209290846.28T8k4Mh005211@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by mckusick:

URL: https://cgit.FreeBSD.org/src/commit/?id=221da3e9212d4cc1e370721493922de232fe3918

commit 221da3e9212d4cc1e370721493922de232fe3918
Author:     Kirk McKusick <mckusick@FreeBSD.org>
AuthorDate: 2022-09-29 08:44:34 +0000
Commit:     Kirk McKusick <mckusick@FreeBSD.org>
CommitDate: 2022-09-29 08:45:41 +0000

    Fix an incorrectly placed parenthesis.
    
    While syntactically correct and even looking correct, it was definitely
    not providing the desired result. And it has been this way for nearly
    twenty years.
    
    MFC after:    2 weeks
    Sponsored by: The FreeBSD Foundation
---
 sys/ufs/ffs/ffs_snapshot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c
index 84983a111fe4..bcdf94a10cda 100644
--- a/sys/ufs/ffs/ffs_snapshot.c
+++ b/sys/ufs/ffs/ffs_snapshot.c
@@ -689,7 +689,7 @@ loop:
 		*blkp++ = lblkno(fs, fs->fs_sblockloc);
 		blkno = fragstoblks(fs, fs->fs_csaddr);
 		for (cg = 0; cg < fs->fs_ncg; cg++) {
-			if (fragstoblks(fs, cgtod(fs, cg) > blkno))
+			if (fragstoblks(fs, cgtod(fs, cg)) > blkno)
 				break;
 			*blkp++ = fragstoblks(fs, cgtod(fs, cg));
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202209290846.28T8k4Mh005211>