From owner-svn-ports-all@FreeBSD.ORG Mon Feb 10 07:52:41 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E4AA4B31; Mon, 10 Feb 2014 07:52:40 +0000 (UTC) Received: from mail-wg0-x22e.google.com (mail-wg0-x22e.google.com [IPv6:2a00:1450:400c:c00::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D51361F76; Mon, 10 Feb 2014 07:52:39 +0000 (UTC) Received: by mail-wg0-f46.google.com with SMTP id x12so3828437wgg.1 for ; Sun, 09 Feb 2014 23:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=2Ep5kQ7mtkt0W9gP+CB3kvGtITfIDs6blYFLd6G6zBw=; b=0yqwen3mrIiuANevNP/TiVTQKDfpacyV8eU5SeldsaaLn3bPq5PpyyHYt3kBJVAkM+ gfjq2qoHRKfhDnUfyDunpnXdRNNOrGrQKwmbAYeq29A3iT5xd8mlKDdFYdH3Gnt9ZYbB xG6DmYnxOns8ZEg5N5AT20uarUIKos/o3QwOSjhHPOXRcMeOOIb3lYI570eOYyWT3RUv ErYuD2l2IxzmKuUMxm6SfIVWFAYTSqs6zS+vzCmapHXazkchB9rv36ipOLuvt8+s9NEc TvSvepWX8SHX7WZVXMAKa+gpk8oclxwcdXo5+Sw6LQeTKElDiBkSrEV2hAHd6f++6E3e jxLw== X-Received: by 10.194.109.68 with SMTP id hq4mr20960402wjb.12.1392018758159; Sun, 09 Feb 2014 23:52:38 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id fb8sm33967375wic.3.2014.02.09.23.52.34 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 09 Feb 2014 23:52:37 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 10 Feb 2014 08:52:32 +0100 From: Baptiste Daroussin To: Steve Wills Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <20140210075232.GU80056@ithaqua.etoilebsd.net> References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cqG5pBpskktEuCrX" Content-Disposition: inline In-Reply-To: <20140210011718.GA79272@mouf.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, John Marino , ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2014 07:52:41 -0000 --cqG5pBpskktEuCrX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2014 at 01:17:22AM +0000, Steve Wills wrote: > On Sun, Feb 09, 2014 at 11:29:17PM +0000, John Marino wrote: > > Author: marino > > Date: Sun Feb 9 23:29:16 2014 > > New Revision: 343559 > > URL: http://svnweb.freebsd.org/changeset/ports/343559 > > QAT: https://qat.redports.org/buildarchive/r343559/ > >=20 > > Log: > > net-p2p/litecoin: Fix DragonFly (broken by OSVERSION) > > =20 > > Limit OSVERSION-based modifications to FreeBSD. This port suddenly > > broken and the use of OSVERSION without OPSYS was the cause. > >=20 > > Modified: > > head/net-p2p/litecoin/Makefile > >=20 > > Modified: head/net-p2p/litecoin/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/net-p2p/litecoin/Makefile Sun Feb 9 23:18:17 2014 (r343558) > > +++ head/net-p2p/litecoin/Makefile Sun Feb 9 23:29:16 2014 (r343559) > > @@ -75,7 +75,7 @@ QMAKE_USE_DBUS=3D 0 > > PLIST_FILES+=3D share/applications/litecoin-qt.desktop share/pixmaps/l= itecoin64.png > > .endif > > =20 > > -.if ${OSVERSION} >=3D 1000054 > > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1000054 > > EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-endian > > .endif > > =20 >=20 > Shouldn't this have required maintainer approval? Or am I confused? >=20 I do not think that requires an approval, as for FreeBSD this change is no-= op, It is also no intrusive and just "fixes" building of that port for Dragonfl= y. My 2ct, Bapt --cqG5pBpskktEuCrX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlL4hUAACgkQ8kTtMUmk6ExUdgCbBeeN5fVSRYKiHTsehCgjlZ9/ 4eQAoKYGvZoxu28gP1SoCjPpst3tk+og =5Col -----END PGP SIGNATURE----- --cqG5pBpskktEuCrX--