From owner-freebsd-ports@FreeBSD.ORG  Sun May 25 09:04:59 2014
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9B41D157
 for <freebsd-ports@freebsd.org>; Sun, 25 May 2014 09:04:59 +0000 (UTC)
Received: from mail.grem.de (outcast.grem.de [213.239.217.27])
 by mx1.freebsd.org (Postfix) with SMTP id 04B052D20
 for <freebsd-ports@freebsd.org>; Sun, 25 May 2014 09:04:58 +0000 (UTC)
Received: (qmail 88695 invoked by uid 89); 25 May 2014 09:04:51 -0000
Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@88.217.180.104)
 by mail.grem.de with ESMTPA; 25 May 2014 09:04:51 -0000
Date: Sun, 25 May 2014 11:04:49 +0200
From: Michael Gmelin <freebsd@grem.de>
To: Fbsd8 <fbsd8@a1poweruser.com>
Subject: Re: Is staging a port really this simple?
Message-ID: <20140525110449.2d63288d@bsd64.grem.de>
In-Reply-To: <5381A672.9080307@a1poweruser.com>
References: <524CE820.5060003@missouri.edu>
 <20131003061511.GF85314@ithaqua.etoilebsd.net>
 <538179d9.ERL3ZKEnk4pQKKib%perryh@pluto.rain.com>
 <5381A672.9080307@a1poweruser.com>
X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.18; amd64-portbld-freebsd9.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: bapt@freebsd.org, Perry Hutchison <perryh@pluto.rain.com>,
 freebsd-ports@freebsd.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 May 2014 09:04:59 -0000

On Sun, 25 May 2014 04:14:42 -0400
Fbsd8 <fbsd8@a1poweruser.com> wrote:

> Perry Hutchison wrote:
> > Some months ago, Baptiste Daroussin <bapt@freebsd.org> wrote:
> > 
> >> ... if you need any help staging your ports I can provide reviews.
> > 
> > I have a couple of ports that need staging support added, and I've
> > finally managed to find time to look into it.  Having read such
> > documentation as I could easily find using Google, and looked at
> > the ports, I am feeling as if I must have overlooked something
> > -- because the only changes that seem to be needed are to insert
> > ${STAGEDIR} into a few lines in the Makefiles.
> > 
> > Granted these are not complex ports, but if it really is this easy
> > I have to wonder what all the uproar has been about :)
> > 
> > What-all have I missed?
> > 
> > --- misc/gtkfind/Makefile
> > +++ misc/gtkfind/Makefile-staged
> > @@ -26,7 +26,7 @@
> >  	${REINPLACE_CMD} -e "s,-O2,${CFLAGS}," ${WRKSRC}/configure
> > ${WRKSRC}/Makefile.in 
> >  do-install:
> > -	${INSTALL_PROGRAM} ${WRKSRC}/gtkfind ${PREFIX}/bin
> > -	${INSTALL_MAN} ${WRKSRC}/gtkfind.1 ${MANPREFIX}/man/man1
> > +	${INSTALL_PROGRAM} ${WRKSRC}/gtkfind
> > ${STAGEDIR}${PREFIX}/bin
> > +	${INSTALL_MAN} ${WRKSRC}/gtkfind.1
> > ${STAGEDIR}${MANPREFIX}/man/man1 
> >  .include <bsd.port.mk>
> > --- sysutils/diskcheckd/Makefile
> > +++ sysutils/diskcheckd/Makefile-staged
> > @@ -19,7 +19,6 @@
> >  MAKEFILE=	/usr/share/mk/bsd.prog.mk
> >  MAKE_ARGS=	PROG=diskcheckd MAN8=${MAN8}
> >  
> > -NO_STAGE=	yes
> >  do-extract:
> >  	@${MKDIR} ${WRKSRC}
> >  .for f in diskcheckd.c diskcheckd.8
> > @@ -30,13 +29,14 @@
> >  	@${REINPLACE_CMD} -e
> > 's|/usr/local/etc/diskcheckd.conf|${PREFIX}/etc/diskcheckd.conf|g'
> > ${WRKSRC}/diskcheckd.8 do-install:
> > -	${INSTALL_PROGRAM} ${WRKSRC}/diskcheckd ${PREFIX}/sbin
> > -	${INSTALL_DATA}	${FILESDIR}/diskcheckd.conf
> > ${PREFIX}/etc/diskcheckd.conf.sample
> > -	${INSTALL_MAN} ${WRKSRC}/diskcheckd.8
> > ${MAN8PREFIX}/man/man8
> > +	${INSTALL_PROGRAM} ${WRKSRC}/diskcheckd
> > ${STAGEDIR}${PREFIX}/sbin
> > +	${INSTALL_DATA}	${FILESDIR}/diskcheckd.conf \
> > +
> > ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf.sample
> > +	${INSTALL_MAN} ${WRKSRC}/diskcheckd.8
> > ${STAGEDIR}${MAN8PREFIX}/man/man8 
> >  post-install:
> > -	@[ -f ${PREFIX}/etc/diskcheckd.conf ] \
> > -		|| ${CP} -p ${PREFIX}/etc/diskcheckd.conf.sample \
> > -			${PREFIX}/etc/diskcheckd.conf
> > +	@[ -f ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf ] \
> > +		|| ${CP} -p
> > ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf.sample \
> > +			${STAGEDIR}${PREFIX}/etc/diskcheckd.conf
> >  
> >  .include <bsd.port.mk>
> 
> 
> 
> Other things to do is "pkg install portlint porttools"
> then from the ports tree location do
> portlint -a
> port test
> make stage
> make check-plist

make check-orphans
make stage-qa

> make install clean
> make deinstall
> 







-- 
Michael Gmelin