Date: Tue, 11 Mar 2014 14:42:16 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alex Kozlov <spam@rm-rf.kiev.ua> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r347857 - head/mail/thunderbird-dictionaries Message-ID: <20140311134216.GL6900@ithaqua.etoilebsd.net> In-Reply-To: <20140311133443.GA26313@ravenloft.kiev.ua> References: <201403110640.s2B6eMDI022100@svn.freebsd.org> <20140311090000.GB78846@FreeBSD.org> <7E2CA333BD6C7A70FD270041@atuin.in.mat.cc> <20140311133443.GA26313@ravenloft.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--E6lVPAHcXg6biC3t
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Mar 11, 2014 at 03:34:43PM +0200, Alex Kozlov wrote:
> On Tue, Mar 11, 2014 at 10:10:43AM +0100, Mathieu Arnold wrote:
> > +--On 11 mars 2014 09:00:00 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
> > wrote:
> > | The way it's done now generates lots of needless mail traffic and repo
> > | churn. It would also be nice if you could provide some details in the
> > | commit logs WRT what's exactly is/was broken. Thank you,
> >=20
> > Well, what was broken is simple, libarchive can't process the zip file =
=66rom
> > the distfiles, and the port needs to use the unzip command.
> I think that in some (many?) cases problem is not in libarchive, but is in
> the difference between tar and unzip. E.g for this port:
>=20
> Index: mail/thunderbird-dictionaries/Makefile
> @@ -15,7 +15,7 @@
> =20
> RUN_DEPENDS=3D thunderbird>=3D6.0:${PORTSDIR}/mail/thunderbird
> =20
> -USES=3D zip:infozip
> +USES=3D zip
> NO_BUILD=3D yes
> WRKSRC=3D ${WRKDIR}/dictionaries
> =20
> @@ -58,7 +58,8 @@
> @${MKDIR} ${WRKSRC}
> .for f in ${ALLDICTS}
> .if ${PORT_OPTIONS:M${f}}
> - @${UNZIP_CMD} -q ${DISTDIR}/${DIST_SUBDIR}/${${f}_FILE} -d ${WRKSRC}/${=
${f}_FILE}
> + @${MKDIR} ${WRKSRC}/${${f}_FILE}
> + @${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${DISTDIR}/${DIST_SUBDIR}/${${f}=
_FILE} -C ${WRKSRC}/${${f}_FILE}
> .endif
> .endfor
> =20
The thing is now everyone can dig for zip:infozip easily and fix them as ne=
eded
regards,
Bapt
--E6lVPAHcXg6biC3t
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlMfErcACgkQ8kTtMUmk6Ey7YACgqHBVmeN0YBGBekOPDpCnKuoL
klAAoLgWqJAVZg8/S0zddPO+iU1/5wtw
=YoDR
-----END PGP SIGNATURE-----
--E6lVPAHcXg6biC3t--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140311134216.GL6900>