From owner-freebsd-current@FreeBSD.ORG Wed May 28 23:24:54 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C50B537B401 for ; Wed, 28 May 2003 23:24:54 -0700 (PDT) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id C423D43F3F for ; Wed, 28 May 2003 23:24:53 -0700 (PDT) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id B7DB9530E; Thu, 29 May 2003 08:24:51 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Pawel Jakub Dawidek References: <20030528214651.GK45118@garage.freebsd.pl> From: Dag-Erling Smorgrav Date: Thu, 29 May 2003 08:24:50 +0200 In-Reply-To: <20030528214651.GK45118@garage.freebsd.pl> (Pawel Jakub Dawidek's message of "Wed, 28 May 2003 23:46:51 +0200") Message-ID: User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii cc: freebsd-current@freebsd.org Subject: Re: pam_unix.c [PATCH]. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2003 06:24:55 -0000 Pawel Jakub Dawidek writes: > I think there is no need to open a PR for this. > Argument 'flags' marked as unused is used in those functions: Yeah. It shouldn't be, though, pretty much everyone (including the Sun engineers in charge of PAM) agrees that PAM_DISALLOW_NULL_AUTHTOK is evil and should go away. DES -- Dag-Erling Smorgrav - des@ofug.org