From owner-svn-src-stable@freebsd.org Wed Mar 28 18:19:46 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A922F6EE07 for ; Wed, 28 Mar 2018 18:19:46 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-yw0-x241.google.com (mail-yw0-x241.google.com [IPv6:2607:f8b0:4002:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DCFC27B7A4 for ; Wed, 28 Mar 2018 18:19:45 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-yw0-x241.google.com with SMTP id x20so1113939ywg.5 for ; Wed, 28 Mar 2018 11:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=27rNzb9IOMhcYWvi/CyiRZBFDDV05vc2S1y8ysHZQIA=; b=zf79myFCxjaX4xmtMm3ZJkqR4M15safUUin6jj9rnoPZd3zJqR+SmyjSVpBPsPGN5R KJ5Pb+Cb9z/0u8PuvoK9D3nusVcdm2IjPTnrtholvtmsooZew5mOx4N5f8lj+b4TazGO i16k8Bu6Ufe3bj8loP9kMar4AhoDaD3LJWb7j56SLigzvPtfgC7snJKJGkYDABvYqT7l sMQs8KHOjYdJ8i+1xS0tF1RmIrMFwt6dMwJ8DXZuf/rnWO7FtEbjgqRUvjgQ93XwQAiL XI75QyGi1+5J0Cx/V7GQiGaD1JvgLZIz4puHnRjUfq4fCBGIGJe+1xdqbPhKG4A/V/6H ouFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=27rNzb9IOMhcYWvi/CyiRZBFDDV05vc2S1y8ysHZQIA=; b=W80Kw5bzOtL68Qq5KaTGxNUX/2I+comxBbPC60tM3HKa4C0qUVB0qBp8Wy+Q+nFRJw f043FYKmYLDQyYFfBmLbX3BdBQwvgcmkAHqFCLtvlRv+nn3/4DRE8xGwI6IDJTR3rb8/ p+5r17OX5aNLaVi0zLORcjojcpkTKFzD34gGA6wbMeUxNgDnBliZd5hXRYuYRIND+DX9 RaJhBILKXbu9/wK0csHKSKW/V5RJSrchTrEWZ4stIP3SoZnAKV7rsLmxF8tLqyJ5SJ3H hGey15wawY3G/mPMiLh1yVpE7Dz/LhflH+V4/EbQuInoPPtRfW7xBrAaVimWMAM6pAzn 8ILw== X-Gm-Message-State: AElRT7FJ6VgebpPzH2E/As+NOzWRFLeG7BnPIv0nLwTRRFK5AAL6xLry nmGXUVjWxlDQ99I/mGyGQxxhHX4PHzheezcoKNiFgQ== X-Google-Smtp-Source: AIpwx481n1xmvOBkujlVuxf+X6CXU5/Smgx/9u3zNcpCSt9IKflpPUpuA9BiwzIV2WbnneonsabsimJ03QiZ9M4E8gE= X-Received: by 10.13.204.146 with SMTP id o140mr2992519ywd.265.1522261185454; Wed, 28 Mar 2018 11:19:45 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:61c5:0:0:0:0:0 with HTTP; Wed, 28 Mar 2018 11:19:45 -0700 (PDT) In-Reply-To: References: <201803140319.w2E3JuGP036341@repo.freebsd.org> From: Oliver Pinter Date: Wed, 28 Mar 2018 20:19:45 +0200 Message-ID: Subject: Re: svn commit: r330897 - in stable/11: bin/cat bin/chflags bin/chmod bin/cp bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/hostname bin/kill bin/ln bin/ls bin/mkdir bin/mv bin/pax bin/ps bi... To: Eitan Adler , cem@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 18:19:46 -0000 On 3/28/18, Oliver Pinter wrote: > Hi! > > This part of the MFC is wrong: > > https://svnweb.freebsd.org/base/stable/11/sys/sys/random.h?limit_changes=0&r1=330897&r2=330896&pathrev=330897 > > Could you please MFC back the other random related changes too? Some > of them made by cem@. Namely these commits: commit b95744ba0ac2f46a95ecbe423a4d8dd7c9513da0 Author: Oliver Pinter Date: Sun Oct 15 17:15:48 2017 +0200 opBSD MFC r324394: random(4): Gather entropy from Pure sources At initialization, hc_source_mask only includes non-Pure sources. The patch changes source registration to enable the registered source in the hc_source_mask bitmask. This mask governs which sources are harvested. This patch also disallows userspace from disabling such sources. PR: 222807 Submitted by: W. Dean Freeman Reviewed by: jmg (earlier version), delphij Approved by: secteam (delphij) Obtained from: HBSD 0054e3e170e083811acc9f3b637f8be8a86c03e7 Security: yes Differential Revision: https://reviews.freebsd.org/D12611 (cherry picked from commit 1c36667f647c87c89227b495e8a79ff1d38a2d31) Author: cem Original-commit-date: Sat Oct 7 19:02:03 2017 +0000 svn-commit-id: /head/ r324394 Signed-off-by: Oliver Pinter commit 6c94c5ce8a5b3ed5dec3bb0437da293de1da22fc Author: Oliver Pinter Date: Sun Oct 15 17:15:43 2017 +0200 opBSD MFC r324393: random(4): Add missing source descriptions Add source descriptions missed in r260847, r303035. While here, convert the array to C99 initializers. Reviewed by: delphij Approved by: secteam (delphij) Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D12618 (cherry picked from commit 25edb3fc554994c75b6282d88b1dd960fd476737) Adopted to 11-STABLE since arm/broadcom/bcm2835/bcm2835_rng.c does not exists here. Author: cem Original-commit-date: Sat Oct 7 18:59:29 2017 +0000 svn-commit-id: /head/ r324393 Signed-off-by: Oliver Pinter commit 28fc9178aca64f2fec46e2753187b35bcab8e962 Author: Oliver Pinter Date: Sun Oct 15 17:15:37 2017 +0200 opBSD MFC r324372: random(4): Discard low entropy inputs The later fields of the harvest_event structure are predictable and provide little value to the entropy pool. Only feed in the relatively high entropy counter and explicit entropy buffer to increase measured input entropy. See also: https://people.freebsd.org/~jmg/vbsdcon_2017_ddfreebsdrng_slides.pdf PR: 222807 Submitted by: W. Dean Freeman Reviewed by: jmg (earlier version), delphij Approved by: secteam (delphij) Obtained from: HBSD 8d809124d563937edd84c9c9d5494406e359c55c Security: no -- low entropy marginal input has no known negative affect on pool quality Differential Revision: https://reviews.freebsd.org/D12610 (cherry picked from commit 1d234c562d594d49fd330eef90cd1b8f0e73f8fa) Author: cem Original-commit-date: Fri Oct 6 18:27:55 2017 +0000 svn-commit-id: /head/ r324372 Signed-off-by: Oliver Pinter > > On 3/14/18, Eitan Adler wrote: >> Author: eadler >> Date: Wed Mar 14 03:19:51 2018 >> New Revision: 330897 >> URL: https://svnweb.freebsd.org/changeset/base/330897 >> [... trim ...]