From owner-cvs-all  Sat Jan  6 14:15:37 2001
From owner-cvs-all@FreeBSD.ORG  Sat Jan  6 14:15:34 2001
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3B6B337B402; Sat,  6 Jan 2001 14:15:34 -0800 (PST)
Received: (from bright@localhost)
	by fw.wintelcom.net (8.10.0/8.10.0) id f06MCwZ22272;
	Sat, 6 Jan 2001 14:12:58 -0800 (PST)
Date: Sat, 6 Jan 2001 14:12:58 -0800
From: Alfred Perlstein <bright@wintelcom.net>
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: Bosko Milekic <bmilekic@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/musycc musycc.c
Message-ID: <20010106141257.F15744@fw.wintelcom.net>
References: <20010106132943.E15744@fw.wintelcom.net> <12666.978817510@critter>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <12666.978817510@critter>; from phk@critter.freebsd.dk on Sat, Jan 06, 2001 at 10:45:10PM +0100
Sender: bright@fw.wintelcom.net
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

* Poul-Henning Kamp <phk@critter.freebsd.dk> [010106 13:45] wrote:
> In message <20010106132943.E15744@fw.wintelcom.net>, Alfred Perlstein writes:
> >* Bosko Milekic <bmilekic@FreeBSD.org> [010106 12:44] wrote:
> >> bmilekic    2001/01/06 12:44:40 PST
> >> 
> >>   Modified files:
> >>     sys/dev/musycc       musycc.c 
> >
> >Grr, This isn't how it was supposed to be done.  Would you mind terribly
> >if I cleaned it up to what I intended it to be:
> 
> 
> 
> >! 		if ((m->m_flags M_EXT) == 0) {
> 
> How is this supposed to compile in either of the committed or proposed
> versions ?

How the hell should I know? :)

not only that but we have one of my favorite bugs:

    while (csc->state != C_RUNNING)
        tsleep(&csc->state, PZERO + PCATCH, "crun", hz/10);

should have no PCATCH, or somehow deal with the signal instead of
looping forever.

You're right, this file is pretty broken. :)

-- 
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
"I have the heart of a child; I keep it in a jar on my desk."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message