From owner-svn-src-head@FreeBSD.ORG Fri Jun 7 10:33:16 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A7CAEB67; Fri, 7 Jun 2013 10:33:16 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) by mx1.freebsd.org (Postfix) with ESMTP id 8FE0316DF; Fri, 7 Jun 2013 10:33:15 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id r57AX8du023313; Fri, 7 Jun 2013 14:33:08 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id r57AX81v023312; Fri, 7 Jun 2013 14:33:08 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 7 Jun 2013 14:33:08 +0400 From: Gleb Smirnoff To: Mikolaj Golub , zec@FreeBSD.org, Nikos Vassiliadis Subject: Re: svn commit: r251490 - head/sys/net Message-ID: <20130607103307.GA1187@FreeBSD.org> References: <201306071027.r57ARpaF056606@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201306071027.r57ARpaF056606@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jun 2013 10:33:16 -0000 On Fri, Jun 07, 2013 at 10:27:51AM +0000, Mikolaj Golub wrote: M> Author: trociny M> Date: Fri Jun 7 10:27:50 2013 M> New Revision: 251490 M> URL: http://svnweb.freebsd.org/changeset/base/251490 M> M> Log: M> Properly set curvnet context in lagg_port_setlladdr() task handler. M> M> Reported by: Nikos Vassiliadis M> Submitted by: zec M> Tested by: Nikos Vassiliadis M> MFC after: 1 week M> M> Modified: M> head/sys/net/if_lagg.c M> M> Modified: head/sys/net/if_lagg.c M> ============================================================================== M> --- head/sys/net/if_lagg.c Fri Jun 7 09:06:50 2013 (r251489) M> +++ head/sys/net/if_lagg.c Fri Jun 7 10:27:50 2013 (r251490) M> @@ -505,7 +505,9 @@ lagg_port_setlladdr(void *arg, int pendi M> ifp = llq->llq_ifp; M> M> /* Set the link layer address */ M> + CURVNET_SET(ifp->if_vnet); M> error = if_setlladdr(ifp, llq->llq_lladdr, ETHER_ADDR_LEN); M> + CURVNET_RESTORE(); M> if (error) M> printf("%s: setlladdr failed on %s\n", __func__, M> ifp->if_xname); IMHO, the entire task function should be embraced into VNET context. -- Totus tuus, Glebius.