Date: Thu, 7 Mar 2013 09:33:00 +1000 (EST) From: Peter Grehan <grehan@freebsd.org> To: "Colin Percival" <cperciva@freebsd.org>, "David Malone" <dwmalone@maths.tcd.ie> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r247871 - head/usr.sbin/bhyve Message-ID: <201303062333.042821@dommail.onthenet.com.au> In-Reply-To: <5137CF1D.3020506@freebsd.org> References: <201303060728.r267SKP3018477@svn.freebsd.org> <20130306231613.GA5146@walton.maths.tcd.ie> <5137CF1D.3020506@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>On 03/06/13 15:16, David Malone wrote: >>> + /* >>> + * We're just computing (a-b) in GF(216). >> >>> + ndesc = (unsigned)*hq->hq_avail_idx - (unsigned)hq->hq_cur_aidx; >> >> I think the comment here is wrong? Subtraction (and addition) in >> GF(2^16) is just xor of 16 bit numbers. You seem to actually be >> working in Z(2^16), where subtraction is normal subtraction mod >> 65536. > >Given that there's no such thing as GF(216) due to 216 = 2^3 * 3^3 not >being a prime power, the comment is definitely wrong. ;-) Any suggestions for better wording ? I submitted the comment block unchanged from the patch. later, Peter. later, Peter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303062333.042821>