Date: Mon, 3 Apr 2023 16:18:20 -0700 From: Kevin Oberman <rkoberman@gmail.com> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: FreeBSD wireless mailing list <wireless@freebsd.org> Subject: Re: Request for testing - firmware crash, wpa, locking Message-ID: <CAN6yY1u_TwMozQMqm387u6_iteHP%2B_mr69ugg7gwFs%2BfSNPpMw@mail.gmail.com> In-Reply-To: <33qn43q-rn1n-prsr-ppr-p846nq875741@mnoonqbm.arg>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Mar 31, 2023 at 1:09 PM Bjoern A. Zeeb <bz@freebsd.org> wrote: > Hi, > > (1) Colin has fixed the panic (after the firmware crash) so many people > keep > seeing. This may mean that you may now (contrary to before) try a > service netif restart wlan0 > to recover from such a crash. This changes is all the way to 13.2. > I am still very pre-occupied with real life but I am hoping that I can > get a possible fix tested and pushed during my Easter "holidays". > > > (2) Along with enweiwu and cy the "startup problem" showing as > "CTRL-EVENT-SCAN-FAILED" was debugged a bit more. We've for now > backed out the rc startup script change and restored the old behaviour > of wpa_supplicant with additional logging. This changes is currently in > main only but will be MFCed to stable/13 in the next week most likely. > If you etcupdate (mergemaster) and pull that change in I would kindly > ask you to turn on debugging for wpa_supplicant and check if you see > any log lines including "(changed)" [beware most should be "(no > change)" along with IFF_UP in the line. If so please contact me. > I still have a hypothesis that we may simply exploit a race in net80211 > there which will need better fixing. > > > (3) if you are using iwlwifi (or rtw88) I just pushed some locking > changes into main. I would appreciate if you could test and let me know > if there are any new regressions (they do not fix the firmware crash > from (1) yet!). > > Lots of health, > /bz > > -- > Bjoern A. Zeeb r15:7 > Bjoern, Just updated to the latest main and received a previously unseen lock order reversal on my iwlwifi when the network came up. This did not prevent the network from starting normally. FreeBSD 14.0-CURRENT #9 main-n261962-41236539d8dd-dirty: Mon Apr 3 13:06:31 PDT 2023 lock order reversal: (sleepable after non-sleepable) 1st 0xfffffe01466a0020 iwlwifi0_com_lo (iwlwifi0_com_lo, sleep mutex) @ /usr/src/sys/net80211/ieee80211_ioctl.c:3552 2nd 0xffffffff81fa9ce0 rtnl cloner lock (rtnl cloner lock, sx) @ /usr/src/sys/netlink/route/iface.c:306 lock order iwlwifi0_com_lo -> rtnl cloner lock attempted at: #0 0xffffffff80c61093 at witness_checkorder+0xbb3 #1 0xffffffff80bfb5b7 at _sx_slock_int+0x67 #2 0xffffffff80e58241 at dump_iface+0x501 #3 0xffffffff80e578cb at rtnl_handle_ifevent+0xab #4 0xffffffff80d70e75 at ieee80211_notify_ifnet_change+0x65 #5 0xffffffff80d9c29f at ieee80211_start_locked+0x6f #6 0xffffffff80d7fd56 at ieee80211_ioctl+0x356 #7 0xffffffff80d1d2d5 at ifhwioctl+0xe05 #8 0xffffffff80d1ecd5 at ifioctl+0x925 #9 0xffffffff80c66cee at kern_ioctl+0x1fe #10 0xffffffff80c66a84 at sys_ioctl+0x154 #11 0xffffffff810e54f0 at amd64_syscall+0x140 #12 0xffffffff810b8b7b at fast_syscall_common+0xf8 I have done no testing, but everything seems to be operating fine. If there is further information I can provide, just let me know. Thanks! -- Kevin Oberman, Part time kid herder and retired Network Engineer E-mail: rkoberman@gmail.com PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683 [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">On Fri, Mar 31, 2023 at 1:09 PM Bjoern A. Zeeb <<a href="mailto:bz@freebsd.org">bz@freebsd.org</a>> wrote:</div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br> <br> (1) Colin has fixed the panic (after the firmware crash) so many people keep<br> seeing. This may mean that you may now (contrary to before) try a<br> service netif restart wlan0<br> to recover from such a crash. This changes is all the way to 13.2.<br> I am still very pre-occupied with real life but I am hoping that I can<br> get a possible fix tested and pushed during my Easter "holidays".<br> <br> <br> (2) Along with enweiwu and cy the "startup problem" showing as<br> "CTRL-EVENT-SCAN-FAILED" was debugged a bit more. We've for now<br> backed out the rc startup script change and restored the old behaviour<br> of wpa_supplicant with additional logging. This changes is currently in<br> main only but will be MFCed to stable/13 in the next week most likely.<br> If you etcupdate (mergemaster) and pull that change in I would kindly<br> ask you to turn on debugging for wpa_supplicant and check if you see<br> any log lines including "(changed)" [beware most should be "(no<br> change)" along with IFF_UP in the line. If so please contact me.<br> I still have a hypothesis that we may simply exploit a race in net80211<br> there which will need better fixing.<br> <br> <br> (3) if you are using iwlwifi (or rtw88) I just pushed some locking<br> changes into main. I would appreciate if you could test and let me know<br> if there are any new regressions (they do not fix the firmware crash<br> from (1) yet!).<br> <br> Lots of health,<br> /bz<br> <br> -- <br> Bjoern A. Zeeb r15:7<br></blockquote><div><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">Bjoern,</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">Just updated to the latest main and received a previously unseen lock order reversal on my iwlwifi when the network came up. This did not prevent the network from starting normally.</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">FreeBSD 14.0-CURRENT #9 main-n261962-41236539d8dd-dirty: Mon Apr 3 13:06:31 PDT 2023</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">lock order reversal: (sleepable after non-sleepable)<br> 1st 0xfffffe01466a0020 iwlwifi0_com_lo (iwlwifi0_com_lo, sleep mutex) @ /usr/src/sys/net80211/ieee80211_ioctl.c:3552<br> 2nd 0xffffffff81fa9ce0 rtnl cloner lock (rtnl cloner lock, sx) @ /usr/src/sys/netlink/route/iface.c:306<br>lock order iwlwifi0_com_lo -> rtnl cloner lock attempted at:<br>#0 0xffffffff80c61093 at witness_checkorder+0xbb3<br>#1 0xffffffff80bfb5b7 at _sx_slock_int+0x67<br>#2 0xffffffff80e58241 at dump_iface+0x501<br>#3 0xffffffff80e578cb at rtnl_handle_ifevent+0xab<br>#4 0xffffffff80d70e75 at ieee80211_notify_ifnet_change+0x65<br>#5 0xffffffff80d9c29f at ieee80211_start_locked+0x6f<br>#6 0xffffffff80d7fd56 at ieee80211_ioctl+0x356<br>#7 0xffffffff80d1d2d5 at <span class="gmail-LI gmail-ng">ifhwioctl+0xe05</span><br>#8 0xffffffff80d1ecd5 at <span class="gmail-LI gmail-ng">ifioctl+0x925</span><br>#9 0xffffffff80c66cee at kern_ioctl+0x1fe<br>#10 0xffffffff80c66a84 at sys_ioctl+0x154<br>#11 0xffffffff810e54f0 at amd64_syscall+0x140<br>#12 0xffffffff810b8b7b at fast_syscall_common+0xf8</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br></div></div></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">I have done no testing, but everything seems to be operating fine.</div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">If there is further information I can provide, just let me know.<br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">Thanks!<br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Kevin Oberman, Part time kid herder and retired Network Engineer<br>E-mail: <a href="mailto:rkoberman@gmail.com" target="_blank">rkoberman@gmail.com</a><br></div><div>PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683</div></div></div></div></div></div></div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAN6yY1u_TwMozQMqm387u6_iteHP%2B_mr69ugg7gwFs%2BfSNPpMw>