From owner-svn-ports-all@FreeBSD.ORG Mon Sep 1 14:47:59 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6E4281F9; Mon, 1 Sep 2014 14:47:59 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 461DD147E; Mon, 1 Sep 2014 14:47:58 +0000 (UTC) Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca [108.170.169.12]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 03E9A1140F2; Mon, 1 Sep 2014 10:47:54 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r366841 - head/lang/tcl86/files From: Adam Weinberger In-Reply-To: <20140901074609.GA32100@FreeBSD.org> Date: Mon, 1 Sep 2014 10:47:50 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <65B530D9-4740-4A60-A2F5-40335A520C4E@adamw.org> References: <201409010731.s817Vrxf062753@svn.freebsd.org> <20140901074609.GA32100@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.1878.6) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Pietro Cerutti X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Sep 2014 14:47:59 -0000 On 1 Sep, 2014, at 3:46, Alexey Dokuchaev wrote: > On Mon, Sep 01, 2014 at 07:31:53AM +0000, Pietro Cerutti wrote: >> New Revision: 366841 >> URL: http://svnweb.freebsd.org/changeset/ports/366841 >> QAT: https://qat.redports.org/buildarchive/r366841/ >>=20 >> Log: >> - Fix customization of Tcl modules path >>=20 >> Modified: >> head/lang/tcl86/files/patch-unix-Makefile.in >>=20 >> Modified: head/lang/tcl86/files/patch-unix-Makefile.in >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/lang/tcl86/files/patch-unix-Makefile.in Mon Sep 1 = 07:26:14 2014 (r366840) >> +++ head/lang/tcl86/files/patch-unix-Makefile.in Mon Sep 1 = 07:31:53 2014 (r366841) >> @@ -1,5 +1,5 @@ >> ---- Makefile.in.orig 2014-08-26 15:23:08 UTC >> -+++ Makefile.in >> +--- Makefile.in.orig 2014-08-26 17:23:08.000000000 +0200 >> ++++ Makefile.in 2014-09-01 09:32:00.000000000 +0200 >=20 > Now isn't it nice: someone corrected the patch header for you, making = it > TZ-agnostic, nice looking without that stupid zer000000000s so = subsequent > commits will have deduced churn. And you've just reverted it back to = the > middle ages. >=20 > Since when did we abandon the practice of doing 'svn diff' before = commit? Alexey, please direct your frustration elsewhere. Pietro fixed = (hopefully) a problem that caused a lot of tcl-dependent ports to break. = He should be commended, not sneered at. If you don=92t like the way = makepatch works, take it up with portmgr, not with the committers who = use it. I know for a fact that portmgr is interested in extending = makepatch to DTRT. Besides, there are simply situations where makepatch is just not the = tool to use. Sometimes I *have* to run diff(1) by hand. Sometimes I need = to run "make patch=94 before I can edit the diff. Sometimes I=92ve = edited multiple files and I want to test one diff at a time. Sometimes a = file needs to be touched by two different patches (I don=92t like it, = but ten years ago it seems like people really did). If you REALLY want to solve that issue, make a change to = src/gnu/usr.bin/diff so that it will take a flag to not put timestamps = in there. Past that, please stop venting at committers about this. I just checked = and I couldn=92t find any time correlation between the Malaysian Air = flights going down and people committing timestamps in patches. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org