From owner-freebsd-stable Mon Mar 23 03:17:59 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA24960 for freebsd-stable-outgoing; Mon, 23 Mar 1998 03:17:59 -0800 (PST) (envelope-from owner-freebsd-stable@FreeBSD.ORG) Received: from whqvax.picker.com (whqvax.picker.com [144.54.1.1]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id DAA24916; Mon, 23 Mar 1998 03:17:41 -0800 (PST) (envelope-from rhh@ct.picker.com) Received: from ct.picker.com by whqvax.picker.com with SMTP; Mon, 23 Mar 1998 6:17:07 -0500 (EST) Received: from elmer.ct.picker.com by ct.picker.com (4.1/SMI-4.1) id AA13222; Mon, 23 Mar 98 06:17:05 EST Received: by elmer.ct.picker.com (SMI-8.6/SMI-SVR4) id GAA14397; Mon, 23 Mar 1998 06:16:37 -0500 Message-Id: <19980323061637.00745@ct.picker.com> Date: Mon, 23 Mar 1998 06:16:37 -0500 From: Randall Hopper To: Amancio Hasty , Mark Murray , asami@FreeBSD.ORG Cc: Joao Carlos Mendes Luis , multimedia@FreeBSD.ORG, stable@FreeBSD.ORG, committers@FreeBSD.ORG Subject: Re: Fxtv vs Stable Mail-Followup-To: Amancio Hasty , Mark Murray , asami@FreeBSD.ORG, Joao Carlos Mendes Luis , multimedia@FreeBSD.ORG, stable@FreeBSD.ORG, committers@FreeBSD.ORG References: <199803230612.IAA03716@greenpeace.grondar.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <199803230612.IAA03716@greenpeace.grondar.za>; from Mark Murray on Mon, Mar 23, 1998 at 08:12:45AM +0200 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk Mark Murray: |Randall Hopper wrote: |> Thanks for the report Mark! Now its just a question of ioctl() or default |> capture start behavior. Then I'll get the fxtv port chg PR in. | |I already have it in my local tree looking like a ports patch. Get the |word from Satoshi, and I'll commit it in no time :-). Mark Murray: |Please may I add the following patch to graphics/fxtv. Without it, fxtv |is useless. If you don't mind doing 2 commits intead of just 1, sure. We still haven't yet resolved who's going to clear that buffer and under what circumstances. Amancio, what do you think about a BT848_CLEAR_ON_START ioctl(). When set to False (the default), behavior is as before -- no clear. When True, the portion of the buffer to be used for captured frames gets cleared before the start is issued. This would avoid having to make fxtv set-uid root or to request signals 1-29 times/sec just to use only the first one for bookkeeping. Thanks, Randall Content-Description: patch-ab |--- ../fxtv-0.46.ORIG/tvcapture.c Tue Oct 28 01:59:41 1997 |+++ tvcapture.c Sun Mar 22 16:43:45 1998 |@@ -1126,7 +1126,7 @@ | /* Just mmap the biggest buffer we'll need and be done with it. */ | /* (Buffer used for non-directvideo captures) */ | c->drv_buf = (TV_UINT8 *) mmap( (caddr_t)0, MAX_MMAP_BUF_SIZE, |- PROT_READ|PROT_WRITE, 0, c->fd, (off_t)0 ); |+ PROT_READ, MAP_SHARED, c->fd, (off_t)0 ); | if ( c->drv_buf == (TV_UINT8 *) -1 ) { | fprintf( stderr, "mmap of driver buffer failed: %s\n", | strerror(errno) ); |@@ -1537,9 +1537,9 @@ | video.ramsize = 0; | | /* If TDEC is on, may be a while before old trash gets written on */ |- if ( c->fps != c->fps_max ) |+/* if ( c->fps != c->fps_max ) | memset( c->drv_buf, '\0', |- g.w * g.h * c->pix_geom_list[ c->pix_geom_idx ].Bpp ); |+ g.w * g.h * c->pix_geom_list[ c->pix_geom_idx ].Bpp ); */ | } | memcpy( &pix_geom, &c->pix_geom_list[ c->pix_geom_idx ], | sizeof( pix_geom ) ); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message