From owner-svn-src-head@freebsd.org Fri Mar 2 02:39:41 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A544DF3FF5F; Fri, 2 Mar 2018 02:39:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5AFA786710; Fri, 2 Mar 2018 02:39:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 55DAF118BD; Fri, 2 Mar 2018 02:39:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w222dfrq062932; Fri, 2 Mar 2018 02:39:41 GMT (envelope-from kevans@FreeBSD.org) Received: (from kevans@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w222dfHK062931; Fri, 2 Mar 2018 02:39:41 GMT (envelope-from kevans@FreeBSD.org) Message-Id: <201803020239.w222dfHK062931@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: kevans set sender to kevans@FreeBSD.org using -f From: Kyle Evans Date: Fri, 2 Mar 2018 02:39:41 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r330262 - head/stand/lua X-SVN-Group: head X-SVN-Commit-Author: kevans X-SVN-Commit-Paths: head/stand/lua X-SVN-Commit-Revision: 330262 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 02:39:41 -0000 Author: kevans Date: Fri Mar 2 02:39:41 2018 New Revision: 330262 URL: https://svnweb.freebsd.org/changeset/base/330262 Log: lualoader: Use #str instead of tracking length with 'n' We really gain almost nothing by tracking length separately, especially when it's as easy as "#str", so reduce complexity. Modified: head/stand/lua/password.lua Modified: head/stand/lua/password.lua ============================================================================== --- head/stand/lua/password.lua Fri Mar 2 02:39:16 2018 (r330261) +++ head/stand/lua/password.lua Fri Mar 2 02:39:41 2018 (r330262) @@ -42,7 +42,6 @@ local twiddle_chars = {"/", "-", "\\", "|"} -- Module exports function password.read(prompt_length) local str = "" - local n = 0 local twiddle_pos = 1 local function draw_twiddle() @@ -60,14 +59,13 @@ function password.read(prompt_length) break end if ch == core.KEY_BACKSPACE or ch == core.KEY_DELETE then - if n > 0 then - n = n - 1 + if #str > 0 then if show_password_mask then loader.printc("\008 \008") else draw_twiddle() end - str = str:sub(1, n) + str = str:sub(1, #str - 1) end else if show_password_mask then @@ -76,7 +74,6 @@ function password.read(prompt_length) draw_twiddle() end str = str .. string.char(ch) - n = n + 1 end end return str