From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Aug  2 21:20:16 2005
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4BF9416A41F
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Tue,  2 Aug 2005 21:20:16 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9748343D46
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Tue,  2 Aug 2005 21:20:15 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j72LKFaZ084129
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Tue, 2 Aug 2005 21:20:15 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j72LKFRS084128;
	Tue, 2 Aug 2005 21:20:15 GMT (envelope-from gnats)
Resent-Date: Tue, 2 Aug 2005 21:20:15 GMT
Resent-Message-Id: <200508022120.j72LKFRS084128@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Stefan `Sec` Zehl <sec@42.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2944716A422
	for <FreeBSD-gnats-submit@freebsd.org>;
	Tue,  2 Aug 2005 21:13:52 +0000 (GMT) (envelope-from sec@42.org)
Received: from ice.42.org (n18-2.dsl.vianetworks.de [194.77.85.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 713F843D49
	for <FreeBSD-gnats-submit@freebsd.org>;
	Tue,  2 Aug 2005 21:13:51 +0000 (GMT) (envelope-from sec@42.org)
Received: by ice.42.org (Postfix, from userid 1000)
	id C28E054D1; Tue,  2 Aug 2005 23:13:49 +0200 (CEST)
Message-Id: <20050802211349.C28E054D1@ice.42.org>
Date: Tue,  2 Aug 2005 23:13:49 +0200 (CEST)
From: Stefan `Sec` Zehl <sec@42.org>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Cc: freebsd-ports@rikrose.net
Subject: ports/84497: security/tor startup script bug
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Stefan `Sec` Zehl <sec@42.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Aug 2005 21:20:16 -0000


>Number:         84497
>Category:       ports
>Synopsis:       security/tor startup script bug
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 02 21:20:15 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Stefan `Sec` Zehl
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD mcp 5.4-STABLE FreeBSD 5.4-STABLE #2: Sat May 21 16:20:09 CEST 2005     root@mcp:/enc/obj/enc/src/sys/MCP  i386

"tor" port installed.

>Description:

the installed /usr/local/etc/rc.d/tor.sh.sample file is broken, it fails to
start tor because of a misorder in the parameter list
	
>How-To-Repeat:

(as root)

mcp:/usr/local/etc/rc.d#sh tor.sh.sample start 
Starting tor...$ 

(now we are running a "_tor" subshell)

	
>Fix:

--- tor.sh.sample       Tue Aug  2 22:43:09 2005
+++ tor.sh      Tue Aug  2 23:05:06 2005
@@ -48,7 +48,7 @@
         if  [ "x$TORUSER" = "x" ]; then
             $TORBIN -f $TORCONF $TORARGS
         else
-            $SUPROG -c "$TORBIN -f $TORCONF $TORARGS" $TORUSER
+            $SUPROG $TORUSER -c "$TORBIN -f $TORCONF $TORARGS"
         fi
         RETVAL=$?
         if [ $RETVAL -eq 0 ]; then


	


>Release-Note:
>Audit-Trail:
>Unformatted: