From owner-cvs-sys  Wed Feb  4 18:57:27 1998
Return-Path: <owner-cvs-sys>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id SAA13936
          for cvs-sys-outgoing; Wed, 4 Feb 1998 18:57:27 -0800 (PST)
          (envelope-from owner-cvs-sys)
Received: from ns1.yes.no (ns1.yes.no [195.119.24.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA13879;
          Wed, 4 Feb 1998 18:56:34 -0800 (PST)
          (envelope-from eivind@bitbox.follo.net)
Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36])
	by ns1.yes.no (8.8.7/8.8.7) with ESMTP id CAA04166;
	Thu, 5 Feb 1998 02:56:32 GMT
Received: (from eivind@localhost)
	by bitbox.follo.net (8.8.6/8.8.6) id DAA01265;
	Thu, 5 Feb 1998 03:56:31 +0100 (MET)
Message-ID: <19980205035631.28915@follo.net>
Date: Thu, 5 Feb 1998 03:56:31 +0100
From: Eivind Eklund <eivind@yes.no>
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: Eivind Eklund <eivind@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
        cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/conf options src/sys/gnu/ext2fs ext2_alloc.c ext2_balloc.c ext2_inode.c ext2_lookup.c ext2_subr.c ext2_vnops.c src/sys/i386/i386 busdma_machdep.c machdep.c pmap.c swtch.s trap.c vm86.c vm_machdep.c src/sys/i386/ibcs2 ibcs2_sysi86.
References: <199802042234.OAA23694@freefall.freebsd.org> <199802050239.VAA19082@khavrinen.lcs.mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.88e
In-Reply-To: <199802050239.VAA19082@khavrinen.lcs.mit.edu>; from Garrett Wollman on Wed, Feb 04, 1998 at 09:39:19PM -0500
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Wed, Feb 04, 1998 at 09:39:19PM -0500, Garrett Wollman wrote:
> <<On Wed, 4 Feb 1998 14:34:06 -0800 (PST), Eivind Eklund <eivind@FreeBSD.ORG> said:
> 
> >   Turn DIAGNOSTIC into a new-style option.
>   
> AIEEE!  You've made DIAGNOSTic totally useless!

Eh?  In the cases where I've used it, I've turned it on for the entire
kernel, but I'll admit I haven't used it much.

If there is a consensus that DIAGNOSTIC should be an old-style option, I'll
be happy to roll it back - making sure it doesn't bitrot due to header file
use would introduce some kludges, too.

However, there are some uses of DIAGNOSTIC (e.g, in vm_zone.h) that require
it to be enabled for corresponding C-files to get support routines. This
implies that at least some people use it as a global option.  Perhaps the
correct thing to do would be to split the option?

Eivind, not out to make anything 'useless'.