From owner-freebsd-hackers@FreeBSD.ORG Wed Jan 14 02:26:00 2015 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 83420A72; Wed, 14 Jan 2015 02:26:00 +0000 (UTC) Received: from mail-la0-x235.google.com (mail-la0-x235.google.com [IPv6:2a00:1450:4010:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 18511FF1; Wed, 14 Jan 2015 02:26:00 +0000 (UTC) Received: by mail-la0-f53.google.com with SMTP id gm9so5852445lab.12; Tue, 13 Jan 2015 18:25:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:from:reply-to:to:cc:references:in-reply-to:subject:date :mime-version:content-type:content-transfer-encoding:thread-index :content-language; bh=WtWIMdgddjNSyrE9FRhtTfO8AdExmF/uhKli+hAv+XQ=; b=Uvc2roI/+JpncOnUdaGNWLp7FhvogE4HnAXQ0IS6uxc05MVCFM3nPOZImLZVM/qzK6 1eo6hH3tpxPe7XqwFsImd7fIbSliulLPLP+MS0VV1ZqqL9Dh8HIKNbLFK8wdlxnpPypZ lfDOpDTFnhQWrXaIuQ4dbiyfgKuhui4kzCCkhOHSHIa86tbL7dkgr8CqtpoVHPfMsxYM ivbGJMvTb6nhjaCRyViTisPa7m4dLBgPxoxLXA9KNvyH6vR/eR4/L5OarkKz2NmP+q50 PflMQq9P8OhSrc7UkvXZSjpwnutzCg9Dg6qWCQKypz3dfyF8PlXpNlOpcYmhrcg1IB8I QZlQ== X-Received: by 10.153.6.6 with SMTP id cq6mr1375672lad.23.1421202358077; Tue, 13 Jan 2015 18:25:58 -0800 (PST) Received: from rimwks1w7x64 ([2001:470:1f15:8e:b007:2759:7397:9491]) by mx.google.com with ESMTPSA id yf10sm5457573lbb.9.2015.01.13.18.25.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Jan 2015 18:25:56 -0800 (PST) Message-ID: <54b5d3b4.2aa3700a.3a6c.25f4@mx.google.com> X-Google-Original-Message-ID: <027901d02fa1$6d929ef0$48b7dcd0$@IM@gmail.com> From: rozhuk.im@gmail.com X-Google-Original-From: Reply-To: To: "'Eric van Gyzen'" , "'Lars Engels'" , "'Allan Jude'" References: <54B35B36.4040504@freebsd.org> <20150113091122.GK67556@e-new.0x20.net> <54B53E40.1030903@vangyzen.net> In-Reply-To: <54B53E40.1030903@vangyzen.net> Subject: RE: [PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged Date: Wed, 14 Jan 2015 05:25:54 +0300 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdAvSGCvsyctOzXxRRqAdAYIqL1KVAAWNGAA Content-Language: ru Cc: freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jan 2015 02:26:00 -0000 > >> Is this feature still useful with memtest.tests=0? > > This feature is useful for everyone who has it set to 1, if they know > > about it or not. So it's a very useful feature. > > Agreed. > > Comments on the patch: > > The patch will divide by zero when PAGE_SIZE > 1 MiB. Maybe remove > PAGES_PER_MB, and just use PAGES_PER_GB. Make it const, too. > > The "total" line is mostly redundant with the later messages regarding > "real memory" and "avail memory". I suggest removing it. > Maybe just write: checked XX megabytes of memory?