From owner-svn-src-all@freebsd.org Mon Feb 1 00:56:19 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5253A73337; Mon, 1 Feb 2016 00:56:19 +0000 (UTC) (envelope-from devin@shxd.cx) Received: from shxd.cx (mail.shxd.cx [64.201.244.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BA89211C4; Mon, 1 Feb 2016 00:56:19 +0000 (UTC) (envelope-from devin@shxd.cx) Received: from [64.201.244.132] (port=50934 helo=[10.0.0.113]) by shxd.cx with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77 (FreeBSD)) (envelope-from ) id 1aQ2mx-0001RL-Hv; Sun, 31 Jan 2016 16:56:19 -0800 Message-ID: <1454288179.18007.6.camel@FreeBSD.org> Subject: Re: svn commit: r295108 - in head/usr.sbin/bsdconfig: . networking/share From: Devin Teske To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: dteske@FreeBSD.org Date: Sun, 31 Jan 2016 16:56:19 -0800 In-Reply-To: <201602010054.u110sQ83065822@repo.freebsd.org> References: <201602010054.u110sQ83065822@repo.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: devin@shxd.cx X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2016 00:56:20 -0000 Typo in commit this commit message; s/snprintf/substr/ (for record posterity) -- Devin On Mon, 2016-02-01 at 00:54 +0000, Devin Teske wrote: > Author: dteske > Date: Mon Feb 1 00:54:26 2016 > New Revision: 295108 > URL: https://svnweb.freebsd.org/changeset/base/295108 > > Log: > Utilize new `-v var_to_set' of f_snprintf() > > Modified: > head/usr.sbin/bsdconfig/bsdconfig > head/usr.sbin/bsdconfig/networking/share/media.subr > head/usr.sbin/bsdconfig/networking/share/resolv.subr > > Modified: head/usr.sbin/bsdconfig/bsdconfig > ===================================================================== > ========= > --- head/usr.sbin/bsdconfig/bsdconfig Mon Feb 1 00:44:29 2016 > (r295107) > +++ head/usr.sbin/bsdconfig/bsdconfig Mon Feb 1 00:54:26 2016 > (r295108) > @@ -212,7 +212,7 @@ dialog_menu_main() > *) menu_program="$menuitem/$menu_program" > esac > > - tag=$( f_substr "$DIALOG_MENU_TAGS" $index 1 ) > + f_substr -v tag "$DIALOG_MENU_TAGS" $index 1 > setvar "menu_program$tag" "$menu_program" > > f_shell_escape "$menu_title" menu_title > @@ -256,7 +256,7 @@ dialog_menu_main() > *) > menu_program="$BSDCFG_LOCAL_LIBE/$menuitem/$menu_program" > esac > > - tag=$( f_substr "$DIALOG_MENU_TAGS" $index 1 ) > + f_substr -v tag "$DIALOG_MENU_TAGS" $index 1 > setvar "menu_program$tag" "$menu_program" > > f_shell_escape "$menu_title" menu_title > > Modified: head/usr.sbin/bsdconfig/networking/share/media.subr > ===================================================================== > ========= > --- head/usr.sbin/bsdconfig/networking/share/media.subr Mon > Feb 1 00:44:29 2016 (r295107) > +++ head/usr.sbin/bsdconfig/networking/share/media.subr Mon > Feb 1 00:54:26 2016 (r295108) > @@ -180,18 +180,18 @@ f_dialog_menu_media_options() > f_ifconfig_media $interface | \ > ( index=1 > > - echo "'$( f_substr "$DIALOG_MENU_TAGS" $index 1 > )'" > - echo "'$opt_none'" > + f_substr -v tagn "$DIALOG_MENU_TAGS" $index 1 > + echo "'$tagn' '$opt_none'" > index=$(( $index + 1 )) > > - echo "'$( f_substr "$DIALOG_MENU_TAGS" $index 1 > )'" > - echo "'$opt_cust'" > + f_substr -v tagn "$DIALOG_MENU_TAGS" $index 1 > + echo "'$tagn' '$opt_cust'" > index=$(( $index + 1 )) > > while read media_options; do > [ $index -lt ${#DIALOG_MENU_TAGS} ] || > break > - echo "'$( f_substr "$DIALOG_MENU_TAGS" > $index 1 )'" > - echo "'$media_options'" > + f_substr -v tagn "$DIALOG_MENU_TAGS" > $index 1 > + echo "'$tagn' '$media_options'" > index=$(( $index + 1 )) > done > ) > > Modified: head/usr.sbin/bsdconfig/networking/share/resolv.subr > ===================================================================== > ========= > --- head/usr.sbin/bsdconfig/networking/share/resolv.subr Mon > Feb 1 00:44:29 2016 (r295107) > +++ head/usr.sbin/bsdconfig/networking/share/resolv.subr Mon > Feb 1 00:54:26 2016 (r295108) > @@ -441,7 +441,7 @@ f_dialog_menu_nameservers() > > for ns in $nameservers; do > [ $index -lt ${#DIALOG_MENU_TAGS} ] > || break > - tag=$( f_substr "$DIALOG_MENU_TAGS" > $index 1 ) > + f_substr -v tag "$DIALOG_MENU_TAGS" > $index 1 > echo "'$tag nameserver' '$ns'" > index=$(( $index + 1 )) > done >