From owner-freebsd-bugs@FreeBSD.ORG Fri Aug 12 21:20:10 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4B7A1065670 for ; Fri, 12 Aug 2011 21:20:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 976D98FC15 for ; Fri, 12 Aug 2011 21:20:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p7CLKAbV056830 for ; Fri, 12 Aug 2011 21:20:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p7CLKANR056829; Fri, 12 Aug 2011 21:20:10 GMT (envelope-from gnats) Resent-Date: Fri, 12 Aug 2011 21:20:10 GMT Resent-Message-Id: <201108122120.p7CLKANR056829@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefano Lattarini Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6C10106564A for ; Fri, 12 Aug 2011 21:12:23 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id A59AC8FC15 for ; Fri, 12 Aug 2011 21:12:23 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p7CLCNtW003787 for ; Fri, 12 Aug 2011 21:12:23 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p7CLCN51003786; Fri, 12 Aug 2011 21:12:23 GMT (envelope-from nobody) Message-Id: <201108122112.p7CLCN51003786@red.freebsd.org> Date: Fri, 12 Aug 2011 21:12:23 GMT From: Stefano Lattarini To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/159730: make(1) in parallel mode fails report failure of @-prefixed recipe using "set +e" X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2011 21:20:10 -0000 >Number: 159730 >Category: bin >Synopsis: make(1) in parallel mode fails report failure of @-prefixed recipe using "set +e" >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Aug 12 21:20:10 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Stefano Lattarini >Release: 8.2-RELEASE >Organization: >Environment: FreeBSD bigio.localdomain 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: When used in parallel mode ("make -jN ..."), FreeBSD make sometimes report successful exit status from recipes that should fail, in case such recipes are prefixed with `@' and unset the `errexit' shell flag. Example: $ echo 'all: ; @set +e; false' | make -j2 -f-; echo status: $? status: 0 I found this problem while testing Automake; see automake bug#9245: This issue causes automake-generated Makefiles using the newer parallel-tests harness to always report success if run with "make -jN check"; a really nasty case of spurious success IMHO, which caused me to label this bug as "serious". >How-To-Repeat: Here is how to reproduce the issue: $ echo 'all: ; @set +e; false' | make -j2 -f-; echo status: $? status: 0 Notice that all of `-j', `@' and `set +e' seems to be required to trigger the bug: $ echo 'all: ; set +e; false' | make -j2 -f- set +e; false *** Error code 1 1 error $ echo 'all: ; @false' | make -j2 -f- *** Error code 1 1 error $ echo 'all: ; @set +e; false' | make -f- *** Error code 1 Stop in /tmp. >Fix: >Release-Note: >Audit-Trail: >Unformatted: