Date: Sat, 06 Dec 2008 21:00:07 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: "=?ISO-8859-1?Q?Marius_N=FCnnerich?=" <marius@nuenneri.ch> Cc: freebsd-geom@freebsd.org Subject: Re: Trivial(?) reorganization of topology lock in geom_event Message-ID: <31114.1228597207@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 04 Dec 2008 21:41:49 %2B0100." <b649e5e0812041241ja4c3886s526590c98e59f629@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <b649e5e0812041241ja4c3886s526590c98e59f629@mail.gmail.com>, "=?ISO- 8859-1?Q?Marius_N=FCnnerich?=" writes: >Hi, > >while working on the DTrace probes for geom I noticed that >g_topology_lock() is called 20 times per second from the g_event >thread, even though the thread only runs 10 times per second when >idle. Maybe it is possible to change the locking like in this patch? I >also changed the position of one unlocking of g_eventlock. In theory the timeout is not necessary, it was added as a stopgap because there were synchronisation issues long time ago. Try dropping the timeout and see if you can provoke problems, if not, kill it. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31114.1228597207>