From owner-svn-src-head@freebsd.org Fri Nov 16 22:52:14 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA1B01107068; Fri, 16 Nov 2018 22:52:14 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DFA286D36F; Fri, 16 Nov 2018 22:52:13 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id B1541200F; Fri, 16 Nov 2018 22:52:13 +0000 (UTC) From: Jan Beich To: Brooks Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338990 - in head/sys: compat/freebsd32 dev/pci References: <201809272108.w8RL8Xqn052122@repo.freebsd.org> Date: Fri, 16 Nov 2018 23:52:09 +0100 Message-ID: <7ehc-y6sm-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: DFA286D36F X-Spamd-Result: default: False [-106.81 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; R_SPF_SOFTFAIL(0.00)[~all]; IP_SCORE(-3.70)[ip: (-9.66), ipnet: 96.47.64.0/20(-4.83), asn: 11403(-3.91), country: US(-0.10)]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-1.00)[-0.995,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2018 22:52:14 -0000 Brooks Davis writes: > Author: brooks > Date: Thu Sep 27 21:08:32 2018 > New Revision: 338990 > URL: https://svnweb.freebsd.org/changeset/base/338990 > > Log: > Centralize compat support for PCIOCGETCONF. > > The pre-7.x compat for both native and 32-bit code was already in > pci_user.c. Use this infrastructure to add implement 32-bit support. > This is more correct as ioctl(2) commands only have meaning in the > context of a file descriptor. > > Reviewed by: kib > Approved by: re (gjb) > Obtained from: CheriBSD > Sponsored by: DARPA, AFRL > Differential revision: https://reviews.freebsd.org/D17324 After this commit getdevice() from pciconf(8) and pci_find_conf() in tools/tools/dmardump/dmardump.c always fail in EPERM in -m32 mode. Found via graphics/libdrm where PCIOCGETCONF is used to get a list of DRM devices for use by OpenGL/Vulkan/VAAPI userland drivers. Can you fix the regression before 12.0R or back the commit out? https://lists.freebsd.org/pipermail/freebsd-current/2018-November/072144.html