From owner-cvs-all Sun Sep 9 18: 8:36 2001 Delivered-To: cvs-all@freebsd.org Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [24.14.150.180]) by hub.freebsd.org (Postfix) with ESMTP id 38C8337B407; Sun, 9 Sep 2001 18:08:24 -0700 (PDT) Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id f8A18NM61176; Sun, 9 Sep 2001 18:08:23 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 75A15390B; Sun, 9 Sep 2001 18:08:23 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Josef Karthauser Cc: Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: CVSROOT cfg.pm commit_prep.pl In-Reply-To: <20010909233407.A846@tao.org.uk> Date: Sun, 09 Sep 2001 18:08:23 -0700 From: Peter Wemm Message-Id: <20010910010823.75A15390B@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Josef Karthauser wrote: > > --zhXaljGHf11kAtnf > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Sun, Sep 09, 2001 at 03:10:06PM +0100, Josef Karthauser wrote: > > On Sat, Sep 08, 2001 at 02:52:54PM -0700, Peter Wemm wrote: > > > This is broken, it happens before the $Id$ spamming checks. You only > > > want this to be run after all the sanity checks are done. Of course th= > en > > > you have to fix all the return's from the function. :-) > >=20 > > You mean that it happens before the spamming checks have had a > > chance to complain? I was so worried about making sure that this > > worked for remote commits I forgot that it probably modifies the > > file directly when committing locally. I'll fix this. > > Hmm, looks like there's no clean way to do this. For a local commit > the local file (in the committers's working directory) is modified. > Unfortunately this all happens before the commit message is entered. > If they abort the commit at this time the file will have already > had it's $Id$ unexpanded. :( Is this acceptable? Yes, but if it is done after the check for each directory, then we should be pretty sure that a regression didn't happen. Note that a empty $tag$ is accepted so the second time around it would still be allowed. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message