From owner-freebsd-toolchain@freebsd.org  Sun Jul  5 10:58:32 2015
Return-Path: <owner-freebsd-toolchain@freebsd.org>
Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6524A552
 for <freebsd-toolchain@mailman.ysv.freebsd.org>;
 Sun,  5 Jul 2015 10:58:32 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 by mx1.freebsd.org (Postfix) with ESMTP id B703E1616
 for <freebsd-toolchain@freebsd.org>; Sun,  5 Jul 2015 10:58:32 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346)
 id AD2F1A360; Sun,  5 Jul 2015 10:58:32 +0000 (UTC)
Date: Sun, 5 Jul 2015 10:58:32 +0000
To: freebsd-toolchain@freebsd.org
From: "dim (Dimitry Andric)" <phabric-noreply@FreeBSD.org>
Reply-to: D2690+334+b4a053d3a7c96652@FreeBSD.org
Subject: [Differential] [Commented On] D2690: In ypbind,
 eliminate error: dereferencing type-punned pointer will break
 strict-aliasing rules
Message-ID: <d5c0f24b159195b5fc5810e154adeaa1@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2690: In ypbind,
 eliminate error: dereferencing type-punned pointer will break
 strict-aliasing rules
X-Herald-Rules: <28>
X-Phabricator-To: <PHID-USER-rqejyyuq725xu4n6pbov>
X-Phabricator-To: <PHID-USER-pjrg7uwimqcazthartyl>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-5dahex5ejhfmjb6awx4r>
X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-USER-k6jzdjowb7pqtu626iin>
In-Reply-To: <differential-rev-PHID-DREV-5wjobtbl22co3qb2erjl-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-5wjobtbl22co3qb2erjl-req@FreeBSD.org>
Thread-Index: Y2M3ODgwNzhlNGU0M2Q5NjMyZTYwOGZmMTc0IFWZDdg=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Jul 2015 10:58:32 -0000

dim added inline comments.

INLINE COMMENTS
  usr.sbin/ypbind/ypbind.c:622 While we are here, can we please update this to a post-K&R definition?  E.g.:
  
      static bool_t broadcast_result(caddr_t out, struct sockaddr_in *addr)

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D2690

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: araujo, bapt, emaste, dim, rodrigc
Cc: imp, freebsd-toolchain-list