From nobody Wed Mar 1 14:48:34 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRcYZ47VVz3txKh; Wed, 1 Mar 2023 14:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRcYZ3bYnz3LSG; Wed, 1 Mar 2023 14:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677682114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F4U4v+IxizOO+lGuncEq1yuLXzkjljbPBZ0c4KYl0aU=; b=W/VQX8qD0AKDFr7y8xDro44sM0LLF5StXsIWZoa5T7ANsJzi/f4UJJ063OpDUQFHJD/bHK mNXdXQoBWJzePcdjNY+Wwtm+odU8U+mfQnM9KHFqR66WoHdZqjsnjB24G8xAIeHNcdcQi0 Lwx9+pAUdW2MjDkTyLNVwgV/41t2GDB6P6Zdym+oVNDGzyxdc6pY82nIfMuafBpfTCt59E FojOM69aoLd0UpBSsFTfdKWcJo5pL0Q6dawkTMWc3e+KoJPZJrccyk8wdpyyxn31cFse8b FqTI9pMG/W/JChXwWMgWB3Js5ve5bluGrmH8mP49hdK9Sgko30/hGUrHtP4vpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677682114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F4U4v+IxizOO+lGuncEq1yuLXzkjljbPBZ0c4KYl0aU=; b=TgQQISGmcFuwEF1ZXt0SCsywQjQH9qN9xHVTPQSK6oZifSLReqibGGd79SWVjRwEP97+ub FJX7tf3yhKGoS0ac/rFXmLqyl+83lZbaTfTRWoZPvUCzAR3EJoJ7/rJ9jO1hnjk8COmttn aSjwIHfDwUiFdjWIzy2GDLQz91Z36X5QYyGMSO9D0eUEng6k6ufhCvUfYlEB79dkPfYyEP owFi5ce2DXIBFaJhgYutLBsnutHNl5Gh+sMPDybNYZw2Ivyl7IKGAKOBxqBvEJTcJ1T2xM AXEjrz072U4L5Ppbh8YgotDJ/XpnaWRmT9E6zK48GLcKaU1W8dTjyPjHj/IFTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677682114; a=rsa-sha256; cv=none; b=unBNLOgCxM5Ymmi1+yN7Ag9kk+lveVu8UrPQhIE7w7erJhwJR82AgG1hJTEEWH9Y5Nj0xn 5OsSJrMnltXcoKgMTmlKfP16QUSSQO28Ufr8fP7Yu8NVNIlROhjRWIEN5iOg7yoD2XxNn8 oKHvQyEE2j14tNvZ2CV2lQ2qfEJMyvGD8xMGPQPwUKWkuvXc4hPLilaGRJ2zgU6ShBJGnK 1GWWccsu1Z53Xd1FWXDwTCp+0dh+4MiiGUW5HtlTWymvUARBthPMH6YqB5ilMS9OS2BTcP nF3pt/LCitE8r1gKxvCVMm6I2+HDo3aMup4MXtGjfGKqIaRBuzfKvuZexok5+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PRcYZ2gQQzdcT; Wed, 1 Mar 2023 14:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 321EmYfT021138; Wed, 1 Mar 2023 14:48:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 321EmYan021137; Wed, 1 Mar 2023 14:48:34 GMT (envelope-from git) Date: Wed, 1 Mar 2023 14:48:34 GMT Message-Id: <202303011448.321EmYan021137@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 5e95f5f53150 - main - thunderx: fix potential sign extension issue List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5e95f5f5315083baa7d98d3286f6c0a82621a68e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=5e95f5f5315083baa7d98d3286f6c0a82621a68e commit 5e95f5f5315083baa7d98d3286f6c0a82621a68e Author: Ed Maste AuthorDate: 2023-02-28 19:17:30 +0000 Commit: Ed Maste CommitDate: 2023-03-01 14:48:17 +0000 thunderx: fix potential sign extension issue Coverity reported a sign extension issue on rq->caching << 26 in the Linux ThunderX driver. (It appears Coverity Scan doesn't build arm64 objects in FreeBSD.) As done in Linux, add a cast. Fixes: 3c0086b81391 ("Raw import of ThunderX VNIC networking driver...") Sponsored by: The FreeBSD Foundation --- sys/dev/vnic/nicvf_queues.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/vnic/nicvf_queues.c b/sys/dev/vnic/nicvf_queues.c index 017d1c6e3e1c..82f045c7777c 100644 --- a/sys/dev/vnic/nicvf_queues.c +++ b/sys/dev/vnic/nicvf_queues.c @@ -1342,7 +1342,7 @@ nicvf_rcv_queue_config(struct nicvf *nic, struct queue_set *qs, mbx.rq.msg = NIC_MBOX_MSG_RQ_CFG; mbx.rq.qs_num = qs->vnic_id; mbx.rq.rq_num = qidx; - mbx.rq.cfg = (rq->caching << 26) | (rq->cq_qs << 19) | + mbx.rq.cfg = ((uint64_t)rq->caching << 26) | (rq->cq_qs << 19) | (rq->cq_idx << 16) | (rq->cont_rbdr_qs << 9) | (rq->cont_qs_rbdr_idx << 8) | (rq->start_rbdr_qs << 1) | (rq->start_qs_rbdr_idx);