From owner-cvs-all  Tue Oct 22  6:20:25 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ECAA537B401; Tue, 22 Oct 2002 06:20:23 -0700 (PDT)
Received: from bast.unixathome.org (bast.unixathome.org [216.187.105.150])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 21F9A43E75; Tue, 22 Oct 2002 06:20:23 -0700 (PDT)
	(envelope-from dan@langille.org)
Received: from wocker (wocker.unixathome.org [192.168.0.99])
	by bast.unixathome.org (Postfix) with ESMTP
	id 11AE03F4B; Tue, 22 Oct 2002 09:20:12 -0400 (EDT)
From: "Dan Langille" <dan@langille.org>
To: Alan Eldridge <alane@FreeBSD.org>, trevor@freebsd.org
Date: Tue, 22 Oct 2002 09:21:46 -0400
MIME-Version: 1.0
Subject: Re: cvs commit: ports/www/phoenix Makefile pkg-descr pkg-plist ports/www/phoenix/files mozconfig.in
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Message-ID: <3DB518AA.8877.232B5847@localhost>
In-reply-to: <200210220926.g9M9QuSA082227@repoman.freebsd.org>
X-mailer: Pegasus Mail for Windows (v4.02a)
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Mail message body
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On 22 Oct 2002 at 2:26, Alan Eldridge wrote:

> alane       2002/10/22 02:26:56 PDT
> 
>   Modified files:
>     www/phoenix          Makefile pkg-descr pkg-plist 
>     www/phoenix/files    mozconfig.in 
>   Log:
>   1. Expanded configure/make options in files/mozconfig.in.
>           * Fixed problem with reliably finding perl 5.8.0.


The problem with this solution is that "make -V PORTVERSION" now 
fails if the perl version is not 5.8.0.  This makes it impossible for 
FreshPorts to do any sanity testing or even determine basic 
information such as the PORTVERSION or PORTNAME.

The code in question is:

.if !defined(PERL_VER) || ${PERL_VER} != 5.8.0
.error This port requires Perl 5.8.0.
.endif

How about marking the port forbidden instead of erroring?  That will 
allow PORTVERSION to be determined and allow sanity testing to 
proceed.

cheers
-- 
Dan Langille


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message