From owner-svn-src-stable-9@FreeBSD.ORG Thu Aug 22 12:47:40 2013 Return-Path: Delivered-To: svn-src-stable-9@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B711DED0; Thu, 22 Aug 2013 12:47:40 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id 76BE42A78; Thu, 22 Aug 2013 12:47:40 +0000 (UTC) Received: from c122-106-156-23.carlnfd1.nsw.optusnet.com.au (c122-106-156-23.carlnfd1.nsw.optusnet.com.au [122.106.156.23]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 6177742466B; Thu, 22 Aug 2013 22:47:32 +1000 (EST) Date: Thu, 22 Aug 2013 22:47:30 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Subject: Re: svn commit: r254626 - stable/9/usr.bin/yacc In-Reply-To: <864naios6h.fsf@nine.des.no> Message-ID: <20130822224100.X2060@besplex.bde.org> References: <201308212257.r7LMvUmY053608@svn.freebsd.org> <8638q2i1oo.fsf@nine.des.no> <86y57ugn00.fsf@nine.des.no> <20130822213005.H1824@besplex.bde.org> <864naios6h.fsf@nine.des.no> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-2098027519-1377175650=:2060" X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=YYGEuWhf c=1 sm=1 tr=0 a=ebeQFi2P/qHVC0Yw9JDJ4g==:117 a=PO7r1zJSAAAA:8 a=Tjuh2rCmyooA:10 a=JzwRw_2MAAAA:8 a=-2CbWcZpqT0A:10 a=nlC_4_pT8q9DhB4Ho9EA:9 a=cz2ZRIgtxKwA:10 a=wJWlkF7cXJYA:10 a=zNDP2BohpHpTM0P1bZ0A:9 a=45ClL6m2LaAA:10 Cc: src-committers@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable-9@FreeBSD.org, "David E. O'Brien" , Bruce Evans X-BeenThere: svn-src-stable-9@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 9-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Aug 2013 12:47:40 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-2098027519-1377175650=:2060 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Thu, 22 Aug 2013, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote: > Bruce Evans writes: >> Dag-Erling Sm=C3=B8rgrav writes: >>> Oh, it's actually our own fault for including -Wredundant-decls in >>> CFLAGS. Is there a good reason to keep it? >> How else would you detect bogus declarations of library functions? Almo= st >> all -W flags are for detecting bugs that are mostly style bugs like this >> one. This one only becomes more than a style bug if: >> - the declaration becomes wrong >> - the header with the correct declaration becomes not included. > > OK, point taken. > ... > So what do you suggest? Revert David's change, or keep it (minus > extern) and remove the prototype from expr.y? > > I favor the latter option, since yyparse() is auto-generated and expr.y > can therefore (strictly speaking) not know what the correct prototype > looks like. Depends what the reason for merging the change is. Is it to cross-build old sources with a current yacc? Then changing the old sources is not so good. It makes them not-old, and missing the declaration going the other way with an old yacc. I now remember not really liking the change to expr.y in -current either for the same reason. It de-portabilizes the sources a little. Bruce --0-2098027519-1377175650=:2060--