From owner-svn-src-head@FreeBSD.ORG  Mon Jan 20 01:59:26 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 400A544B;
 Mon, 20 Jan 2014 01:59:26 +0000 (UTC)
Received: from lauren.room52.net (lauren.room52.net [210.50.193.198])
 by mx1.freebsd.org (Postfix) with ESMTP id 0352C1104;
 Mon, 20 Jan 2014 01:59:25 +0000 (UTC)
Received: from lgwl-lstewart2.corp.netflix.com
 (lstewart-laptop.caia.swin.edu.au [136.186.229.148])
 by lauren.room52.net (Postfix) with ESMTPSA id AB1957E924;
 Mon, 20 Jan 2014 12:51:13 +1100 (EST)
Message-ID: <52DC810B.3080103@freebsd.org>
Date: Mon, 20 Jan 2014 12:51:07 +1100
From: Lawrence Stewart <lstewart@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: "Alexander V. Chernikov" <melifaro@FreeBSD.org>, 
 src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, 
 svn-src-head@FreeBSD.org
Subject: Re: svn commit: r260702 - head/sys/netinet
References: <201401161150.s0GBo1c1069638@svn.freebsd.org>
In-Reply-To: <201401161150.s0GBo1c1069638@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
 autolearn=unavailable version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lauren.room52.net
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2014 01:59:26 -0000

On 01/16/14 22:50, Alexander V. Chernikov wrote:
> Author: melifaro
> Date: Thu Jan 16 11:50:00 2014
> New Revision: 260702
> URL: http://svnweb.freebsd.org/changeset/base/260702
> 
> Log:
>   Fix ipfw fwd for IPv4 traffic broken by r249894.
>   
>   Problem case:
>   Original lookup returns route with GW set, so gw points to
>   rte->rt_gateway.
>   After that we're changing dst and performing lookup another time.
>   Since fwd host is most probably directly reachable, resulting
>   rte does not contain rt_gateway, so gw is not set. Finally, we
>   end with packet transmitted to proper interface but wrong
>   link-layer address.
>   
>   Found by:	lstewart
>   Discussed with:	ae,lstewart
>   MFC after:	2 weeks
>   Sponsored by:	Yandex LLC

Thanks again for fixing this Alexander. Is the setfib fix going to hit
the tree soon as well?

Cheers,
Lawrence