Date: Wed, 27 Jan 1999 22:12:31 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: John Birrell <jb@cimlogic.com.au> Cc: nate@mt.sri.com (Nate Williams), archie@whistle.com, wollman@khavrinen.lcs.mit.edu, current@FreeBSD.ORG Subject: Re: btokup() macro in sys/malloc.h Message-ID: <199901280612.WAA93764@apollo.backplane.com> References: <199901280558.QAA07918@cimlogic.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
:I think you must mean the "Sydney-down-under constituent". There *is*
:a difference. 8-)
:
:> 'warnings' fixes will be wrong and hide bogus code), making -Wall a goal
:> causes people to cover up bad code with bad casts and such.
:>
:> '-Wall' is *NOT* a good design goal.
:
:Fixing warnings with bad casts is a problem, sure, but asking people
:to write code without casts (if possible) that will compile cleanly with
:-Wall is a reasonable thing to ask IMO. In my experience, the resulting
:code tends to be more portable across architectures with different
:pointer/long sizes and endian-ness.
:
:Just my 0.02, and I hate style(9) anyway.
Not to mention that I was also able to enable -Wcast-qual. That is a
MAJOR step forward, people. Just for starters it caught a serious bug
in the kernel getenv(). Being able to use const the way it's supposed
to be used is important... VERY important, and until now the kernel's
been casting things in and out of const and volatile almost at will,
not mention improperly declaring const pointers verses pointer-to-const
and other things.
-Matt
Matthew Dillon
<dillon@backplane.com>
:--
:John Birrell - jb@cimlogic.com.au; jb@freebsd.org http://www.cimlogic.com.au/
:CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137
:
:To Unsubscribe: send mail to majordomo@FreeBSD.org
:with "unsubscribe freebsd-current" in the body of the message
:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280612.WAA93764>